This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107936/

Ship it!

Aside the less technical questions below, it looks fine.

kwin/clients/aurorae/src/aurorae.cpp (Diff revision 1)
		QRegion AuroraeClient::region(KDecorationDefines::Region r)
		604	rect.translate(- paddingLeft, - paddingTop);

coding style? ;-P

kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml (Diff revision 1)

		23	root.extendedBorderTop = 0;

too specific? (does Aurorae support vertical titlebars in this context?)

kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml (Diff revision 1)

		38	enableExtendedBorders();

me and iirc also hugo only use them to cover the "no border" case, not as addition to a present border

does Aurorae support zero borders or would this be an opportunity to introduce them?

- Thomas

On December 27th, 2012, 7:59 a.m., Martin Gräßlin wrote:

Review request for kwin.

By Martin Gräßlin.

Updated Dec. 27, 2012, 7:59 a.m.

Description

Extended Border support in Aurorae

Aurorae Themes can make use of the extended borders feature to allow
resizing outside the window decoration area. So far only Plastik makes
use of it in the Tiny border case.

This should be extended in future by adding generic NoSideBorders and
NoBorders sizes as used by Oxygen.

FEATURE: 308992
FIXED-IN: 4.11

Bugs: 308992

Diffs

kwin/clients/aurorae/src/aurorae.h (6e187eaeb9973692aebba8883d4c3783606a1336)
kwin/clients/aurorae/src/aurorae.cpp (b6c219b72fca87fa4adefa3e1a590a81bf0d1f5f)
kwin/clients/aurorae/src/qml/Decoration.qml (b885278be7a8ec3874ce7ca5bfa8ba500a65f025)
kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml (d18d7a78e736a15197b4a1bc8c9e6126b5e3264f)

View Diff