'Re: Review Request: Support brightness > 1 on XRender backend'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Support brightness > 1 on XRender backend
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-12-23 9:17:06
Message-ID: 20121223091706.3378.80035 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Dec. 23, 2012, 8:42 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> > does a brightness value > 1 make any sense in general? If not it might =
be easier to change WindowPaintData to ensure that the brightness value doe=
sn't get larger than 1.0

Yupp ;-)

I changed my animations to no longer bump scale but brightness on activatio=
n (some sort of white flash - black looks weird in this case) and noticed i=
t does not work with XRender.

- Thomas

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107854/#review23881
-----------------------------------------------------------

On Dec. 22, 2012, 10:55 p.m., Thomas L=C3=BCbking wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107854/
> -----------------------------------------------------------
> =

> (Updated Dec. 22, 2012, 10:55 p.m.)
> =

> =

> Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
> =

> =

> Description
> -------
> =

> summarized
> =

> =

> Diffs
> -----
> =

>   kwin/scene_xrender.cpp 4ee755a =

> =

> Diff: http://git.reviewboard.kde.org/r/107854/diff/
> =

> =

> Testing
> -------
> =

> yes.
> =

> =

> Thanks,
> =

> Thomas L=C3=BCbking
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107854/">http://git.reviewboard.kde.org/r/107854/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On December 23rd, 2012, 8:42 a.m., <b>Martin \
Gräßlin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">does a brightness value &gt; 1 make any sense in general? If not it \
might be easier to change WindowPaintData to ensure that the brightness value \
doesn&#39;t get larger than 1.0</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yupp ;-)

I changed my animations to no longer bump scale but brightness on activation (some \
sort of white flash - black looks weird in this case) and noticed it does not work \
with XRender.</pre> <br />

<p>- Thomas</p>

<br />
<p>On December 22nd, 2012, 10:55 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Dec. 22, 2012, 10:55 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">summarized</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/scene_xrender.cpp <span style="color: grey">(4ee755a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107854/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 