This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107854/

On December 23rd, 2012, 8:42 a.m., Martin Gräßlin wrote:

does a brightness value > 1 make any sense in general? If not it might be easier to change WindowPaintData to ensure that the brightness value doesn't get larger than 1.0
Yupp ;-)

I changed my animations to no longer bump scale but brightness on activation (some sort of white flash - black looks weird in this case) and noticed it does not work with XRender.

- Thomas


On December 22nd, 2012, 10:55 p.m., Thomas Lübking wrote:

Review request for kwin and Martin Gräßlin.
By Thomas Lübking.

Updated Dec. 22, 2012, 10:55 p.m.

Description

summarized

Testing

yes.

Diffs

  • kwin/scene_xrender.cpp (4ee755a)

View Diff