[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: avoid nulluid activity
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-12-23 9:23:23
Message-ID: 20121223092323.4578.41444 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 23, 2012, 8:43 a.m., Martin Gräßlin wrote:
> > kwin/client.cpp, lines 1509-1510
> > <http://git.reviewboard.kde.org/r/107855/diff/1/?file=100652#file100652line1509>
> >
> > @Ivan: can we do something here that we don't have to hardcode that value?
>
> Ivan Čukić wrote:
> Well, you could check whether the uuid is null, which is essentially the same, \
> maybe slower :)
> The idea for nulluid is that even if somebody disables kamd, applications get at \
> least one activity present (so that plasma doesn't show an empty desktop for \
> example)
> In any case, nulluid should never show up at the same time as any of the other \
> activities. If it does, it is a kamd bug (and I'm thinking that I might have missed \
> the ActivityRemoved/Added signals for it when the client detects that the service \
> is down/up.
> For KWin, handling that state as ALL activities seems sufficient.
> Well, you could check whether the uuid is null, which is essentially the same, \
> maybe slower :)
Regarding that and ooc: why are the ids btw. not just quint64 but strings (i never \
understood that - i just smells like it will make several things clumsy)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107855/#review23882
-----------------------------------------------------------
On Dec. 22, 2012, 11:01 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107855/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2012, 11:01 p.m.)
>
>
> Review request for kwin, Ivan Čukić and Martin Gräßlin.
>
>
> Description
> -------
>
> This is replied as activity by the lib cache in case the server is (yet) not up, \
> but no window should ever be assigned to it - so we should rather remove it (and in \
> doubt treat this as "all activities" condition)
>
> Diffs
> -----
>
> kwin/client.cpp b555c11
>
> Diff: http://git.reviewboard.kde.org/r/107855/diff/
>
>
> Testing
> -------
>
> semi - i once ran into one or more window/s being on that id, not with the patch \
> since after (surprise)
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107855/">http://git.reviewboard.kde.org/r/107855/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 23rd, 2012, 8:43 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/107855/diff/1/?file=100652#file100652line1509" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/client.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Client::setOnActivity(const QString &activity, bool enable)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1509</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">// nulluid - invalid. in doubt resolves to empty list, ie. \
"ALL"</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1510</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">newActivitiesList</span><span class="p">.</span><span \
class="n">removeAll</span><span class="p">(</span><span \
class="s">"00000000-0000-0000-0000-000000000000"</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@Ivan: can we do \
something here that we don't have to hardcode that value?</pre> </blockquote>
<p>On December 23rd, 2012, 8:53 a.m., <b>Ivan Čukić</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, you could check \
whether the uuid is null, which is essentially the same, maybe slower :)
The idea for nulluid is that even if somebody disables kamd, applications get at \
least one activity present (so that plasma doesn't show an empty desktop for \
example)
In any case, nulluid should never show up at the same time as any of the other \
activities. If it does, it is a kamd bug (and I'm thinking that I might have \
missed the ActivityRemoved/Added signals for it when the client detects that the \
service is down/up.
For KWin, handling that state as ALL activities seems sufficient.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> Well, \
you could check whether the uuid is null, which is essentially the same, maybe slower \
:) Regarding that and ooc: why are the ids btw. not just quint64 but strings (i never \
understood that - i just smells like it will make several things clumsy)</pre> <br />
<p>- Thomas</p>
<br />
<p>On December 22nd, 2012, 11:01 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Ivan Čukić and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Dec. 22, 2012, 11:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is replied as activity by the lib cache in case the server is (yet) \
not up, but no window should ever be assigned to it - so we should rather remove it \
(and in doubt treat this as "all activities" condition)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">semi - i once ran into one or more window/s being on that id, not with \
the patch since after (surprise)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/client.cpp <span style="color: grey">(b555c11)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107855/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic