From kwin Sun Dec 23 09:17:06 2012 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Sun, 23 Dec 2012 09:17:06 +0000 To: kwin Subject: Re: Review Request: Support brightness > 1 on XRender backend Message-Id: <20121223091706.3378.80035 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=135625423627018 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3778168658713578542==" --===============3778168658713578542== Content-Type: multipart/alternative; boundary="===============2490904559394859095==" --===============2490904559394859095== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Dec. 23, 2012, 8:42 a.m., Martin Gr=C3=A4=C3=9Flin wrote: > > does a brightness value > 1 make any sense in general? If not it might = be easier to change WindowPaintData to ensure that the brightness value doe= sn't get larger than 1.0 Yupp ;-) I changed my animations to no longer bump scale but brightness on activatio= n (some sort of white flash - black looks weird in this case) and noticed i= t does not work with XRender. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107854/#review23881 ----------------------------------------------------------- On Dec. 22, 2012, 10:55 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107854/ > ----------------------------------------------------------- > = > (Updated Dec. 22, 2012, 10:55 p.m.) > = > = > Review request for kwin and Martin Gr=C3=A4=C3=9Flin. > = > = > Description > ------- > = > summarized > = > = > Diffs > ----- > = > kwin/scene_xrender.cpp 4ee755a = > = > Diff: http://git.reviewboard.kde.org/r/107854/diff/ > = > = > Testing > ------- > = > yes. > = > = > Thanks, > = > Thomas L=C3=BCbking > = > --===============2490904559394859095== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107854/

On December 23rd, 2012, 8:42 a.m., Martin G= r=C3=A4=C3=9Flin wrote:

does a br=
ightness value > 1 make any sense in general? If not it might be easier =
to change WindowPaintData to ensure that the brightness value doesn't g=
et larger than 1.0

Yupp ;-)

I changed my animations to no longer bump scale but brightness on activatio=
n (some sort of white flash - black looks weird in this case) and noticed i=
t does not work with XRender.

- Thomas

On December 22nd, 2012, 10:55 p.m., Thomas L=C3=BCbking wrote:

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.

By Thomas L=C3=BCbking.

Updated Dec. 22, 2012, 10:55 p.m.

Descripti= on

summarized

Testing <= /h1>

yes.

Diffs=

kwin/scene_xrender.cpp (4ee755a)

View Diff

--===============2490904559394859095==-- --===============3778168658713578542== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============3778168658713578542==--