[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.
From: "Antonis Tsiapaliokas" <kok3rs () gmail ! com>
Date: 2012-08-29 18:08:35
Message-ID: 20120829180835.14399.50047 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 27, 2012, 4:32 p.m., Sebastian Kügler wrote:
> > mainwindow.cpp, line 1026
> > <http://git.reviewboard.kde.org/r/106118/diff/3/?file=81728#file81728line1026>
> >
> > Why not just } else { ?
Sorry for my late reply but i am/will be very busy for the following days.
Because we always want to clean the tmpFile and to add an objectName.
Also i done that for the consistency of the code. I thought that it would be better \
to look as much possible as it could with the "createPreviewerFor".
- Antonis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106118/#review18117
-----------------------------------------------------------
On Aug. 27, 2012, 4:06 p.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106118/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2012, 4:06 p.m.)
>
>
> Review request for kwin, Plasma, Sebastian Kügler, Martin Gräßlin, and Giorgos \
> Tsiapaliwkas.
>
> Description
> -------
>
> Hello,
>
> This patch is adding the konsolepreviewer support to the KWin Scripts.
> When the user, is pressing the "Execute" button, then the script is being called.
> Also on the toolbar, there is a new action with name "konsole". This action is \
> visible only when we are inside to a KWin Script. All the other packages, have a \
> previewer. So the "konsole" action is located inside the previewer.
>
> Diffs
> -----
>
> konsole/konsolepreviewer.h 8dd4369
> konsole/konsolepreviewer.cpp c4f9f8b
> main.cpp 298be51
> mainwindow.h 8005d26
> mainwindow.cpp b84da4a
> plasmateui.rc b51884d
> publisher/remoteinstaller/remoteinstaller.cpp a54d453
>
> Diff: http://git.reviewboard.kde.org/r/106118/diff/
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> konsole
> http://git.reviewboard.kde.org/r/106118/s/693/
>
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106118/">http://git.reviewboard.kde.org/r/106118/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 27th, 2012, 4:32 p.m., <b>Sebastian \
Kügler</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106118/diff/3/?file=81728#file81728line1026" \
style="color: black; font-weight: bold; text-decoration: \
underline;">mainwindow.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">KonsolePreviewer* MainWindow::createKonsoleFor(const QString& projectType, \
const QString &packagePath)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1022</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">konsole</span><span \
class="p">)</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why not just } else { \
?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry for \
my late reply but i am/will be very busy for the following days.
Because we always want to clean the tmpFile and to add an objectName.
Also i done that for the consistency of the code. I thought that it would be better \
to look as much possible as it could with the "createPreviewerFor".</pre> \
<br />
<p>- Antonis</p>
<br />
<p>On August 27th, 2012, 4:06 p.m., Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Plasma, Sebastian Kügler, Martin Gräßlin, and \
Giorgos Tsiapaliwkas.</div> <div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Aug. 27, 2012, 4:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
This patch is adding the konsolepreviewer support to the KWin Scripts.
When the user, is pressing the "Execute" button, then the script is being \
called. Also on the toolbar, there is a new action with name "konsole". \
This action is visible only when we are inside to a KWin Script. All the other \
packages, have a previewer. So the "konsole" action is located inside the \
previewer.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konsole/konsolepreviewer.h <span style="color: grey">(8dd4369)</span></li>
<li>konsole/konsolepreviewer.cpp <span style="color: grey">(c4f9f8b)</span></li>
<li>main.cpp <span style="color: grey">(298be51)</span></li>
<li>mainwindow.h <span style="color: grey">(8005d26)</span></li>
<li>mainwindow.cpp <span style="color: grey">(b84da4a)</span></li>
<li>plasmateui.rc <span style="color: grey">(b51884d)</span></li>
<li>publisher/remoteinstaller/remoteinstaller.cpp <span style="color: \
grey">(a54d453)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106118/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106118/s/693/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/22/kwin_script_konsole_previewer_400x100.png" \
style="border: 1px black solid;" alt="konsole" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic