From kwin Wed Aug 29 18:08:35 2012 From: "Antonis Tsiapaliokas" Date: Wed, 29 Aug 2012 18:08:35 +0000 To: kwin Subject: Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer. Message-Id: <20120829180835.14399.50047 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=134626373806191 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6501476177141991248==" --===============6501476177141991248== Content-Type: multipart/alternative; boundary="===============4245429682224703333==" --===============4245429682224703333== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Aug. 27, 2012, 4:32 p.m., Sebastian K=C3=BCgler wrote: > > mainwindow.cpp, line 1026 > > > > > > Why not just } else { ? Sorry for my late reply but i am/will be very busy for the following days. Because we always want to clean the tmpFile and to add an objectName. Also i done that for the consistency of the code. I thought that it would b= e better to look as much possible as it could with the "createPreviewerFor". - Antonis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/#review18117 ----------------------------------------------------------- On Aug. 27, 2012, 4:06 p.m., Antonis Tsiapaliokas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106118/ > ----------------------------------------------------------- > = > (Updated Aug. 27, 2012, 4:06 p.m.) > = > = > Review request for kwin, Plasma, Sebastian K=C3=BCgler, Martin Gr=C3=A4= =C3=9Flin, and Giorgos Tsiapaliwkas. > = > = > Description > ------- > = > Hello, > = > This patch is adding the konsolepreviewer support to the KWin Scripts. > When the user, is pressing the "Execute" button, then the script is being= called. > Also on the toolbar, there is a new action with name "konsole". This acti= on is visible only when we are inside to a KWin Script. > All the other packages, have a previewer. So the "konsole" action is loca= ted inside the previewer. > = > = > Diffs > ----- > = > konsole/konsolepreviewer.h 8dd4369 = > konsole/konsolepreviewer.cpp c4f9f8b = > main.cpp 298be51 = > mainwindow.h 8005d26 = > mainwindow.cpp b84da4a = > plasmateui.rc b51884d = > publisher/remoteinstaller/remoteinstaller.cpp a54d453 = > = > Diff: http://git.reviewboard.kde.org/r/106118/diff/ > = > = > Testing > ------- > = > = > Screenshots > ----------- > = > konsole > http://git.reviewboard.kde.org/r/106118/s/693/ > = > = > Thanks, > = > Antonis Tsiapaliokas > = > --===============4245429682224703333== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106118/

On August 27th, 2012, 4:32 p.m., Sebastian = K=C3=BCgler wrote:
= = =
mainwindow.cpp (Diff revision 3)
KonsolePreviewer* MainWindow::createKonsoleFor(const QString& p=
rojectType, const QString &packagePath)
1022
    if (konsole) {
Why not j=
ust } else { ?

Sorry for my late reply but i am/will be very busy for the following=
 days.

Because we always want to clean the tmpFile and to add an objectName.

Also i done that for the consistency of the code. I thought that it would b=
e better to look as much possible as it could with the "createPreviewe=
rFor".

- Antonis

On August 27th, 2012, 4:06 p.m., Antonis Tsiapaliokas wrote:

Review request for kwin, Plasma, Sebastian K=C3=BCgler, Martin Gr=C3= =A4=C3=9Flin, and Giorgos Tsiapaliwkas.

By Antonis Tsiapaliokas.

Updated Aug. 27, 2012, 4:06 p.m.

Descripti= on

Hello,

This patch is adding the konsolepreviewer support to the KWin Scripts.
When the user, is pressing the "Execute" button, then the script =
is being called.
Also on the toolbar, there is a new action with name "konsole". T=
his action is visible only when we are inside to a KWin Script.
All the other packages, have a previewer. So the "konsole" action=
 is located inside the previewer.

Diffs=

konsole/konsolepreviewer.h (8dd4369)
konsole/konsolepreviewer.cpp (c4f9f8b)
main.cpp (298be51)
mainwindow.h (8005d26)
mainwindow.cpp (b84da4a)
plasmateui.rc (b51884d)
publisher/remoteinstaller/remoteinstaller.cpp (a54d453)

Screensho= ts

3D"kons=

--===============4245429682224703333==-- --===============6501476177141991248== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============6501476177141991248==--