'Review Request: Correctly align tabbing shade mode, including hover'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: Correctly align tabbing shade mode, including hover
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-08-28 20:16:36
Message-ID: 20120828201636.7965.38051 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106258/
-----------------------------------------------------------

Review request for kwin and Martin Gräßlin.

Description
-------

Right now the shading state is not really aligned because everything that's not \
ShadeNone will lead to ShadeNormal - including ShadeHover. Also an early return can \
omit the alignment in setShade() (because if (was_shade == isShade()) does not mean \
the actual same shadeMode()) Finally the tabgroup is not respected when unhovering \
the shade (this is important because it's called through a timer and the main client \
may have been unshaded and reshading it here would align all shadestates, including \
the dominant one)

This addresses bug 294410.
    http://bugs.kde.org/show_bug.cgi?id=294410

Diffs
-----

  kwin/client.cpp 39f41c3 
  kwin/tabgroup.cpp 6109f9f 

Diff: http://git.reviewboard.kde.org/r/106258/diff/

Testing
-------

yes, shaded some windows

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106258/">http://git.reviewboard.kde.org/r/106258/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Right now the shading state is not really aligned because everything \
that&#39;s not ShadeNone will lead to ShadeNormal - including ShadeHover. Also an \
early return can omit the alignment in setShade() (because if (was_shade == \
isShade()) does not mean the actual same shadeMode()) Finally the tabgroup is not \
respected when unhovering the shade (this is important because it&#39;s called \
through a timer and the main client may have been unshaded and reshading it here \
would align all shadestates, including the dominant one)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes, shaded some windows</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=294410">294410</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/client.cpp <span style="color: grey">(39f41c3)</span></li>

 <li>kwin/tabgroup.cpp <span style="color: grey">(6109f9f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106258/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 