--===============2642754076855987254== Content-Type: multipart/alternative; boundary="===============1907201476884085951==" --===============1907201476884085951== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106258/ ----------------------------------------------------------- Review request for kwin and Martin Gr=C3=A4=C3=9Flin. Description ------- Right now the shading state is not really aligned because everything that's= not ShadeNone will lead to ShadeNormal - including ShadeHover. Also an early return can omit the alignment in setShade() (because if (was_= shade =3D=3D isShade()) does not mean the actual same shadeMode()) Finally the tabgroup is not respected when unhovering the shade (this is im= portant because it's called through a timer and the main client may have be= en unshaded and reshading it here would align all shadestates, including th= e dominant one) This addresses bug 294410. http://bugs.kde.org/show_bug.cgi?id=3D294410 Diffs ----- kwin/client.cpp 39f41c3 = kwin/tabgroup.cpp 6109f9f = Diff: http://git.reviewboard.kde.org/r/106258/diff/ Testing ------- yes, shaded some windows Thanks, Thomas L=C3=BCbking --===============1907201476884085951== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106258/

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
By Thomas L=C3=BCbking.

Descripti= on 

Right now the shading state is not really aligned because ev=
erything that's not ShadeNone will lead to ShadeNormal - including Shad=
eHover.
Also an early return can omit the alignment in setShade() (because if (was_=
shade =3D=3D isShade()) does not mean the actual same shadeMode())
Finally the tabgroup is not respected when unhovering the shade (this is im=
portant because it's called through a timer and the main client may hav=
e been unshaded and reshading it here would align all shadestates, includin=
g the dominant one)

Testing <= /h1> 
yes, shaded some windows
Bugs: 294410

Diffs=

  • kwin/client.cpp (39f41c3)
  • kwin/tabgroup.cpp (6109f9f)

View Diff
--===============1907201476884085951==-- --===============2642754076855987254== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============2642754076855987254==--