This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106258/

Review request for kwin and Martin Gräßlin.
By Thomas Lübking.

Description

Right now the shading state is not really aligned because everything that's not ShadeNone will lead to ShadeNormal - including ShadeHover.
Also an early return can omit the alignment in setShade() (because if (was_shade == isShade()) does not mean the actual same shadeMode())
Finally the tabgroup is not respected when unhovering the shade (this is important because it's called through a timer and the main client may have been unshaded and reshading it here would align all shadestates, including the dominant one)

Testing

yes, shaded some windows
Bugs: 294410

Diffs

  • kwin/client.cpp (39f41c3)
  • kwin/tabgroup.cpp (6109f9f)

View Diff