[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Add Cursor key navigation to Flip- and Cover Switch Effects
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-03-31 20:51:00
Message-ID: 20120331205100.31073.68082 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 31, 2012, 8:38 p.m., Thomas Lübking wrote:
> > The tabbox isn't rtl aware at all, is it?
>
> Martin Gräßlin wrote:
> that's a good question, I think no (for effects) and I have no idea whether QML is \
> rtl aware at all.
TextItem is, for the tabbox i'd say we just revert stacking order resp. focus chain \
and next/prev shortcut binding.
Remained keayboard usage (but that's not so much an issue, because even if "right" \
means "back", it still means "right" ;-)
I just happened to wonder when looking at the patch.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104438/#review12078
-----------------------------------------------------------
On March 29, 2012, 6:42 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104438/
> -----------------------------------------------------------
>
> (Updated March 29, 2012, 6:42 p.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> FlipSwitch can be navigated with up and down keys and CoverSwitch with left and \
> right keys while Alt+Tab is used.
>
> This addresses bug 178595.
> http://bugs.kde.org/show_bug.cgi?id=178595
>
>
> Diffs
> -----
>
> kwin/effects/coverswitch/coverswitch.h b7a9da3
> kwin/effects/coverswitch/coverswitch.cpp fe517d0
> kwin/effects/flipswitch/flipswitch.h f3fca73
> kwin/effects/flipswitch/flipswitch.cpp a32c47c
>
> Diff: http://git.reviewboard.kde.org/r/104438/diff/
>
>
> Testing
> -------
>
> yes :-)
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104438/">http://git.reviewboard.kde.org/r/104438/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 31st, 2012, 8:38 p.m., <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The tabbox isn't rtl aware at all, is it?</pre> </blockquote>
<p>On March 31st, 2012, 8:44 p.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">that's a good \
question, I think no (for effects) and I have no idea whether QML is rtl aware at \
all.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">TextItem is, for the \
tabbox i'd say we just revert stacking order resp. focus chain and next/prev \
shortcut binding.
Remained keayboard usage (but that's not so much an issue, because even if \
"right" means "back", it still means "right" ;-)
I just happened to wonder when looking at the patch.</pre>
<br />
<p>- Thomas</p>
<br />
<p>On March 29th, 2012, 6:42 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 29, 2012, 6:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">FlipSwitch can be navigated with up and down keys and CoverSwitch with \
left and right keys while Alt+Tab is used.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes :-)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=178595">178595</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/coverswitch/coverswitch.h <span style="color: \
grey">(b7a9da3)</span></li>
<li>kwin/effects/coverswitch/coverswitch.cpp <span style="color: \
grey">(fe517d0)</span></li>
<li>kwin/effects/flipswitch/flipswitch.h <span style="color: \
grey">(f3fca73)</span></li>
<li>kwin/effects/flipswitch/flipswitch.cpp <span style="color: \
grey">(a32c47c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104438/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic