From kwin Sat Mar 31 20:51:00 2012 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Sat, 31 Mar 2012 20:51:00 +0000 To: kwin Subject: Re: Review Request: Add Cursor key navigation to Flip- and Cover Switch Effects Message-Id: <20120331205100.31073.68082 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=133322714813261 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6034413368871340743==" --===============6034413368871340743== Content-Type: multipart/alternative; boundary="===============7405561652942073312==" --===============7405561652942073312== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On March 31, 2012, 8:38 p.m., Thomas L=C3=BCbking wrote: > > The tabbox isn't rtl aware at all, is it? > = > Martin Gr=C3=A4=C3=9Flin wrote: > that's a good question, I think no (for effects) and I have no idea w= hether QML is rtl aware at all. TextItem is, for the tabbox i'd say we just revert stacking order resp. foc= us chain and next/prev shortcut binding. Remained keayboard usage (but that's not so much an issue, because even if = "right" means "back", it still means "right" ;-) I just happened to wonder when looking at the patch. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104438/#review12078 ----------------------------------------------------------- On March 29, 2012, 6:42 p.m., Martin Gr=C3=A4=C3=9Flin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104438/ > ----------------------------------------------------------- > = > (Updated March 29, 2012, 6:42 p.m.) > = > = > Review request for kwin. > = > = > Description > ------- > = > FlipSwitch can be navigated with up and down keys and CoverSwitch with le= ft and right keys while Alt+Tab is used. > = > = > This addresses bug 178595. > http://bugs.kde.org/show_bug.cgi?id=3D178595 > = > = > Diffs > ----- > = > kwin/effects/coverswitch/coverswitch.h b7a9da3 = > kwin/effects/coverswitch/coverswitch.cpp fe517d0 = > kwin/effects/flipswitch/flipswitch.h f3fca73 = > kwin/effects/flipswitch/flipswitch.cpp a32c47c = > = > Diff: http://git.reviewboard.kde.org/r/104438/diff/ > = > = > Testing > ------- > = > yes :-) > = > = > Thanks, > = > Martin Gr=C3=A4=C3=9Flin > = > --===============7405561652942073312== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104438/

On March 31st, 2012, 8:38 p.m., Thomas L=C3= =BCbking wrote:

The tabbo=
x isn't rtl aware at all, is it?

On March 31st, 2012, 8:44 p.m., Martin Gr=C3=A4=C3=9Flin wrote:<= /p> 

that'=
s a good question, I think no (for effects) and I have no idea whether QML =
is rtl aware at all.
TextItem is=
, for the tabbox i'd say we just revert stacking order resp. focus chai=
n and next/prev shortcut binding.

Remained keayboard usage (but that's not so much an issue, because even=
 if "right" means "back", it still means "right&qu=
ot; ;-)

I just happened to wonder when looking at the patch.

- Thomas


On March 29th, 2012, 6:42 p.m., Martin Gr=C3=A4=C3=9Flin wrote:

Review request for kwin.
By Martin Gr=C3=A4=C3=9Flin.

Updated March 29, 2012, 6:42 p.m.

Descripti= on 

FlipSwitch can be navigated with up and down keys and CoverS=
witch with left and right keys while Alt+Tab is used.

Testing <= /h1> 
yes :-)
Bugs: 178595

Diffs=

  • kwin/effects/coverswitch/coverswitch.h (b7= a9da3)
  • kwin/effects/coverswitch/coverswitch.cpp (= fe517d0)
  • kwin/effects/flipswitch/flipswitch.h (f3fc= a73)
  • kwin/effects/flipswitch/flipswitch.cpp (a3= 2c47c)

View Diff
--===============7405561652942073312==-- --===============6034413368871340743== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============6034413368871340743==--