[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Synchronize Show Desktop Wording in TabBox Effects
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-03-31 20:44:22
Message-ID: 20120331204422.30547.43208 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 29, 2012, 3:22 p.m., Thomas Lübking wrote:
> > kwin/effects/coverswitch/coverswitch.cpp, line 581
> > <http://git.reviewboard.kde.org/r/104436/diff/1/?file=55136#file55136line581>
> >
> > maybe the icon should be set in ::updateCaption() as well?
>
> Martin Gräßlin wrote:
> As icon currently everywhere (including layout based switchers) the normal Plasma \
> Icon is used. I think it makes sense to change that to the more generic "Show \
> Desktop" icon as used by the Plasmoid and will open a Review Request for it.
What i meant is that (now) updateIcon() and updateCaption() seem to always come as \
pair so it might have made sense to just set the icon as part of the caption with \
updateCaption() as well. *shrug*
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104436/#review11986
-----------------------------------------------------------
On March 29, 2012, 8:40 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104436/
> -----------------------------------------------------------
>
> (Updated March 29, 2012, 8:40 a.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> Use "Show Desktop" for the desktop entry with the same message as in "normal" \
> TabBox.
> BoxSwitch is not adjusted as it's scheduled for removal in 4.9
>
>
> This addresses bug 273478.
> http://bugs.kde.org/show_bug.cgi?id=273478
>
>
> Diffs
> -----
>
> kwin/effects/coverswitch/coverswitch.h b7a9da3
> kwin/effects/coverswitch/coverswitch.cpp fe517d0
> kwin/effects/flipswitch/flipswitch.h f3fca73
> kwin/effects/flipswitch/flipswitch.cpp a32c47c
>
> Diff: http://git.reviewboard.kde.org/r/104436/diff/
>
>
> Testing
> -------
>
> yes :-)
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104436/">http://git.reviewboard.kde.org/r/104436/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 29th, 2012, 3:22 p.m., <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104436/diff/1/?file=55136#file55136line581" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/effects/coverswitch/coverswitch.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
CoverSwitchEffect::slotTabBoxAdded(int mode)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">581</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">captionFrame</span><span class="o">-></span><span \
class="n">setIcon</span><span class="p">(</span><span \
class="n">selected_window</span><span class="o">-></span><span \
class="n">icon</span><span class="p">());</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">581</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">captionFrame</span><span class="o">-></span><span \
class="n">setIcon</span><span class="p">(</span><span \
class="n">selected_window</span><span class="o">-></span><span \
class="n">icon</span><span class="p">());</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">maybe the icon should be \
set in ::updateCaption() as well?</pre> </blockquote>
<p>On March 29th, 2012, 3:29 p.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As icon currently \
everywhere (including layout based switchers) the normal Plasma Icon is used. I think \
it makes sense to change that to the more generic "Show Desktop" icon as \
used by the Plasmoid and will open a Review Request for it.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What i \
meant is that (now) updateIcon() and updateCaption() seem to always come as pair so \
it might have made sense to just set the icon as part of the caption with \
updateCaption() as well. *shrug*</pre> <br />
<p>- Thomas</p>
<br />
<p>On March 29th, 2012, 8:40 a.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 29, 2012, 8:40 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use "Show Desktop" for the desktop entry with the same message \
as in "normal" TabBox.
BoxSwitch is not adjusted as it's scheduled for removal in 4.9
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes :-)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=273478">273478</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/coverswitch/coverswitch.h <span style="color: \
grey">(b7a9da3)</span></li>
<li>kwin/effects/coverswitch/coverswitch.cpp <span style="color: \
grey">(fe517d0)</span></li>
<li>kwin/effects/flipswitch/flipswitch.h <span style="color: \
grey">(f3fca73)</span></li>
<li>kwin/effects/flipswitch/flipswitch.cpp <span style="color: \
grey">(a32c47c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104436/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic