This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104438/

On March 31st, 2012, 8:38 p.m., Thomas Lübking wrote:

The tabbox isn't rtl aware at all, is it?

On March 31st, 2012, 8:44 p.m., Martin Gräßlin wrote:

that's a good question, I think no (for effects) and I have no idea whether QML is rtl aware at all.
TextItem is, for the tabbox i'd say we just revert stacking order resp. focus chain and next/prev shortcut binding.

Remained keayboard usage (but that's not so much an issue, because even if "right" means "back", it still means "right" ;-)

I just happened to wonder when looking at the patch.

- Thomas


On March 29th, 2012, 6:42 p.m., Martin Gräßlin wrote:

Review request for kwin.
By Martin Gräßlin.

Updated March 29, 2012, 6:42 p.m.

Description

FlipSwitch can be navigated with up and down keys and CoverSwitch with left and right keys while Alt+Tab is used.

Testing

yes :-)
Bugs: 178595

Diffs

  • kwin/effects/coverswitch/coverswitch.h (b7a9da3)
  • kwin/effects/coverswitch/coverswitch.cpp (fe517d0)
  • kwin/effects/flipswitch/flipswitch.h (f3fca73)
  • kwin/effects/flipswitch/flipswitch.cpp (a32c47c)

View Diff