--===============2862147800732199568== Content-Type: multipart/alternative; boundary="===============3846704324128605523==" --===============3846704324128605523== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On March 29, 2012, 3:22 p.m., Thomas L=C3=BCbking wrote: > > kwin/effects/coverswitch/coverswitch.cpp, line 581 > > > > > > maybe the icon should be set in ::updateCaption() as well? > = > Martin Gr=C3=A4=C3=9Flin wrote: > As icon currently everywhere (including layout based switchers) the n= ormal Plasma Icon is used. I think it makes sense to change that to the mor= e generic "Show Desktop" icon as used by the Plasmoid and will open a Revie= w Request for it. What i meant is that (now) updateIcon() and updateCaption() seem to always = come as pair so it might have made sense to just set the icon as part of th= e caption with updateCaption() as well. *shrug* - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104436/#review11986 ----------------------------------------------------------- On March 29, 2012, 8:40 a.m., Martin Gr=C3=A4=C3=9Flin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104436/ > ----------------------------------------------------------- > = > (Updated March 29, 2012, 8:40 a.m.) > = > = > Review request for kwin. > = > = > Description > ------- > = > Use "Show Desktop" for the desktop entry with the same message as in "nor= mal" TabBox. > = > BoxSwitch is not adjusted as it's scheduled for removal in 4.9 > = > = > This addresses bug 273478. > http://bugs.kde.org/show_bug.cgi?id=3D273478 > = > = > Diffs > ----- > = > kwin/effects/coverswitch/coverswitch.h b7a9da3 = > kwin/effects/coverswitch/coverswitch.cpp fe517d0 = > kwin/effects/flipswitch/flipswitch.h f3fca73 = > kwin/effects/flipswitch/flipswitch.cpp a32c47c = > = > Diff: http://git.reviewboard.kde.org/r/104436/diff/ > = > = > Testing > ------- > = > yes :-) > = > = > Thanks, > = > Martin Gr=C3=A4=C3=9Flin > = > --===============3846704324128605523== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104436/

On March 29th, 2012, 3:22 p.m., Thomas L=C3= =BCbking wrote:

= = =
kwin/effects/coverswitch/coverswitch.cpp (Diff revision 1) 
void CoverSwitchEffect::slotTabBoxAdded(int mode)
581 
                    captionF=
rame->setIcon(selected_window->icon());
 581 
                    captionF=
rame->setIcon(selected_window->icon());
 
maybe the=
 icon should be set in ::updateCaption() as well?

On March 29th, 2012, 3:29 p.m., Martin Gr=C3=A4=C3=9Flin wrote:<= /p> 

As icon c=
urrently everywhere (including layout based switchers) the normal Plasma Ic=
on is used. I think it makes sense to change that to the more generic "=
;Show Desktop" icon as used by the Plasmoid and will open a Review Req=
uest for it.
What i meant is that (now) updateIcon() and updateCaption() seem to =
always come as pair so it might have made sense to just set the icon as par=
t of the caption with updateCaption() as well. *shrug*

- Thomas


On March 29th, 2012, 8:40 a.m., Martin Gr=C3=A4=C3=9Flin wrote:

Review request for kwin.
By Martin Gr=C3=A4=C3=9Flin.

Updated March 29, 2012, 8:40 a.m.

Descripti= on 

Use "Show Desktop" for the desktop entry with the =
same message as in "normal" TabBox.

BoxSwitch is not adjusted as it's scheduled for removal in 4.9

Testing <= /h1> 
yes :-)
Bugs: 273478

Diffs=

  • kwin/effects/coverswitch/coverswitch.h (b7= a9da3)
  • kwin/effects/coverswitch/coverswitch.cpp (= fe517d0)
  • kwin/effects/flipswitch/flipswitch.h (f3fc= a73)
  • kwin/effects/flipswitch/flipswitch.cpp (a3= 2c47c)

View Diff
--===============3846704324128605523==-- --===============2862147800732199568== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============2862147800732199568==--