On March 29th, 2012, 3:22 p.m., Thomas Lübking wrote:

kwin/effects/coverswitch/coverswitch.cpp (Diff revision 1)
void CoverSwitchEffect::slotTabBoxAdded(int mode)
581	captionFrame->setIcon(selected_window->icon());	581	captionFrame->setIcon(selected_window->icon());

maybe the icon should be set in ::updateCaption() as well?

On March 29th, 2012, 3:29 p.m., Martin Gräßlin wrote:

As icon currently everywhere (including layout based switchers) the normal Plasma Icon is used. I think it makes sense to change that to the more generic "Show Desktop" icon as used by the Plasmoid and will open a Review Request for it.

What i meant is that (now) updateIcon() and updateCaption() seem to always come as pair so it might have made sense to just set the icon as part of the caption with updateCaption() as well. *shrug*

- Thomas

On March 29th, 2012, 8:40 a.m., Martin Gräßlin wrote:

Use "Show Desktop" for the desktop entry with the same message as in "normal" TabBox.

BoxSwitch is not adjusted as it's scheduled for removal in 4.9

yes :-)