[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Drop refresh method on D-Bus interface
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-03-26 20:32:46
Message-ID: 20120326203246.5882.20899 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104418/#review11889
-----------------------------------------------------------
Ship it!
=)
Apparently kwin had it's own "xrefresh" what's a workaround for server glitches and \
close to pointless on a composited desktop (because the clients won't get an exposure \
event)
Also "xrefresh" should be shipped with any relevant distro anyway.
- Thomas Lübking
On March 26, 2012, 8:27 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104418/
> -----------------------------------------------------------
>
> (Updated March 26, 2012, 8:27 p.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> The method is nowhere called inside KWin, nor used as a slot.
> It's also not used from any of the KCMs and the method does not
> do what the name says. It just shows and hides a window as big
> as the screen geometry.
>
> I tried my best to search with lxr.kde.org, but it's a too generic name. I searched \
> over kde-workspace for "org.kde.KWin" and at least there is no direct method call \
> through the D-Bus interface.
> Unless someone knows what it is supposed to do, I would like to remove the code.
>
>
> Diffs
> -----
>
> kwin/org.kde.KWin.xml 160f94e
> kwin/workspace.h 1c6a831
> kwin/workspace.cpp 5542a3d
>
> Diff: http://git.reviewboard.kde.org/r/104418/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104418/">http://git.reviewboard.kde.org/r/104418/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">=) Apparently kwin had \
it's own "xrefresh" what's a workaround for server glitches and \
close to pointless on a composited desktop (because the clients won't get an \
exposure event)
Also "xrefresh" should be shipped with any relevant distro anyway.</pre>
<br />
<p>- Thomas</p>
<br />
<p>On March 26th, 2012, 8:27 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 26, 2012, 8:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The method is nowhere called inside KWin, nor used as a slot. It's \
also not used from any of the KCMs and the method does not do what the name says. It \
just shows and hides a window as big as the screen geometry.
I tried my best to search with lxr.kde.org, but it's a too generic name. I \
searched over kde-workspace for "org.kde.KWin" and at least there is no \
direct method call through the D-Bus interface.
Unless someone knows what it is supposed to do, I would like to remove the \
code.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/org.kde.KWin.xml <span style="color: grey">(160f94e)</span></li>
<li>kwin/workspace.h <span style="color: grey">(1c6a831)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(5542a3d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104418/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic