From kwin Mon Mar 26 20:32:46 2012 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Mon, 26 Mar 2012 20:32:46 +0000 To: kwin Subject: Re: Review Request: Drop refresh method on D-Bus interface Message-Id: <20120326203246.5882.20899 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=133279404718182 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6362996832771445307==" --===============6362996832771445307== Content-Type: multipart/alternative; boundary="===============6076769281691109201==" --===============6076769281691109201== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104418/#review11889 ----------------------------------------------------------- Ship it! =3D) Apparently kwin had it's own "xrefresh" what's a workaround for server glit= ches and close to pointless on a composited desktop (because the clients wo= n't get an exposure event) Also "xrefresh" should be shipped with any relevant distro anyway. - Thomas L=C3=BCbking On March 26, 2012, 8:27 p.m., Martin Gr=C3=A4=C3=9Flin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104418/ > ----------------------------------------------------------- > = > (Updated March 26, 2012, 8:27 p.m.) > = > = > Review request for kwin. > = > = > Description > ------- > = > The method is nowhere called inside KWin, nor used as a slot. > It's also not used from any of the KCMs and the method does not > do what the name says. It just shows and hides a window as big > as the screen geometry. > = > I tried my best to search with lxr.kde.org, but it's a too generic name. = I searched over kde-workspace for "org.kde.KWin" and at least there is no d= irect method call through the D-Bus interface. > = > Unless someone knows what it is supposed to do, I would like to remove th= e code. > = > = > Diffs > ----- > = > kwin/org.kde.KWin.xml 160f94e = > kwin/workspace.h 1c6a831 = > kwin/workspace.cpp 5542a3d = > = > Diff: http://git.reviewboard.kde.org/r/104418/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Martin Gr=C3=A4=C3=9Flin > = > --===============6076769281691109201== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104418/

Ship it!

=3D)
Apparently kwin had it's own "xrefresh" what's a workarou=
nd for server glitches and close to pointless on a composited desktop (beca=
use the clients won't get an exposure event)

Also "xrefresh" should be shipped with any relevant distro anyway=
.

- Thomas


On March 26th, 2012, 8:27 p.m., Martin Gr=C3=A4=C3=9Flin wrote:

Review request for kwin.
By Martin Gr=C3=A4=C3=9Flin.

Updated March 26, 2012, 8:27 p.m.

Descripti= on 

The method is nowhere called inside KWin, nor used as a slot.
It's also not used from any of the KCMs and the method does not
do what the name says. It just shows and hides a window as big
as the screen geometry.

I tried my best to search with lxr.kde.org, but it's a too generic name=
. I searched over kde-workspace for "org.kde.KWin" and at least t=
here is no direct method call through the D-Bus interface.

Unless someone knows what it is supposed to do, I would like to remove the =
code.

Diffs=

  • kwin/org.kde.KWin.xml (160f94e)
  • kwin/workspace.h (1c6a831)
  • kwin/workspace.cpp (5542a3d)

View Diff
--===============6076769281691109201==-- --===============6362996832771445307== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============6362996832771445307==--