This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104418/

Ship it!

=)
Apparently kwin had it's own "xrefresh" what's a workaround for server glitches and close to pointless on a composited desktop (because the clients won't get an exposure event)

Also "xrefresh" should be shipped with any relevant distro anyway.

- Thomas


On March 26th, 2012, 8:27 p.m., Martin Gräßlin wrote:

Review request for kwin.
By Martin Gräßlin.

Updated March 26, 2012, 8:27 p.m.

Description 

The method is nowhere called inside KWin, nor used as a slot.
It's also not used from any of the KCMs and the method does not
do what the name says. It just shows and hides a window as big
as the screen geometry.

I tried my best to search with lxr.kde.org, but it's a too generic name. I searched over kde-workspace for "org.kde.KWin" and at least there is no direct method call through the D-Bus interface.

Unless someone knows what it is supposed to do, I would like to remove the code.

Diffs

  • kwin/org.kde.KWin.xml (160f94e)
  • kwin/workspace.h (1c6a831)
  • kwin/workspace.cpp (5542a3d)

View Diff