'Re: Review Request: Drop refresh method on D-Bus interface'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Drop refresh method on D-Bus interface
From:       "Commit Hook" <null () kde ! org>
Date:       2012-04-01 6:17:41
Message-ID: 20120401061741.1117.57374 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104418/#review12088
-----------------------------------------------------------

This review has been submitted with commit 1336b3ac3efdae9365bb3d17db7231b4=
117fc904 by Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit Hook

On March 26, 2012, 8:27 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104418/
> -----------------------------------------------------------
> =

> (Updated March 26, 2012, 8:27 p.m.)
> =

> =

> Review request for kwin.
> =

> =

> Description
> -------
> =

> The method is nowhere called inside KWin, nor used as a slot.
> It's also not used from any of the KCMs and the method does not
> do what the name says. It just shows and hides a window as big
> as the screen geometry.
> =

> I tried my best to search with lxr.kde.org, but it's a too generic name. =
I searched over kde-workspace for "org.kde.KWin" and at least there is no d=
irect method call through the D-Bus interface.
> =

> Unless someone knows what it is supposed to do, I would like to remove th=
e code.
> =

> =

> Diffs
> -----
> =

>   kwin/org.kde.KWin.xml 160f94e =

>   kwin/workspace.h 1c6a831 =

>   kwin/workspace.cpp 5542a3d =

> =

> Diff: http://git.reviewboard.kde.org/r/104418/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104418/">http://git.reviewboard.kde.org/r/104418/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 1336b3ac3efdae9365bb3d17db7231b4117fc904 by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On March 26th, 2012, 8:27 p.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated March 26, 2012, 8:27 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The method is nowhere called inside KWin, nor used as a slot. It&#39;s \
also not used from any of the KCMs and the method does not do what the name says. It \
just shows and hides a window as big as the screen geometry.

I tried my best to search with lxr.kde.org, but it&#39;s a too generic name. I \
searched over kde-workspace for &quot;org.kde.KWin&quot; and at least there is no \
direct method call through the D-Bus interface.

Unless someone knows what it is supposed to do, I would like to remove the \
code.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/org.kde.KWin.xml <span style="color: grey">(160f94e)</span></li>

 <li>kwin/workspace.h <span style="color: grey">(1c6a831)</span></li>

 <li>kwin/workspace.cpp <span style="color: grey">(5542a3d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104418/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 