'Re: Review Request: Refactoring of KWin Options: turn it into a QObject and provide properties'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Refactoring of KWin Options: turn it into a QObject and provide properties
From:       "Commit Hook" <null () kde ! org>
Date:       2012-02-27 18:34:45
Message-ID: 20120227183445.1480.13851 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104036/#review10962
-----------------------------------------------------------

This review has been submitted with commit 99c2f420bd6c0c0bac8fc7964ddeb5f1=
50b23be3 by Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit Hook

On Feb. 21, 2012, 8:28 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104036/
> -----------------------------------------------------------
> =

> (Updated Feb. 21, 2012, 8:28 a.m.)
> =

> =

> Review request for kwin.
> =

> =

> Description
> -------
> =

> Rational: I want to have all options available as at least read-only to s=
cripts.
> =

> For this Options need to inherit QObject and provide properties. For prop=
erties we need public getters instead of public access to the memeber varia=
bles. So this changes:
> * remove all public member variables and replace them by getters
> * inherit QObject and export properties
> =

> Btw only one option was unused.
> =

> =

> Diffs
> -----
> =

>   kwin/activation.cpp d954059 =

>   kwin/client.cpp 34e9006 =

>   kwin/composite.cpp 6a10d34 =

>   kwin/effects.cpp 9602df3 =

>   kwin/events.cpp e249eca1 =

>   kwin/geometry.cpp b447838 =

>   kwin/layers.cpp 397ff6f =

>   kwin/manage.cpp e74c607 =

>   kwin/options.h 67f2259 =

>   kwin/options.cpp f745ec4 =

>   kwin/placement.cpp 1e6209c =

>   kwin/scene_opengl.cpp f0971a2 =

>   kwin/scene_opengl_egl.cpp 9868006 =

>   kwin/scene_opengl_glx.cpp 1c6b235 =

>   kwin/scene_xrender.cpp 9ff2db6 =

>   kwin/screenedge.cpp 9734a1e =

>   kwin/tabbox/tabbox.cpp 3f26397 =

>   kwin/tiling/tiling.cpp 5257284 =

>   kwin/tilinglayoutfactory.cpp 78734e9 =

>   kwin/useractions.cpp 1eaf3e2 =

>   kwin/workspace.cpp 4f9ee18 =

> =

> Diff: http://git.reviewboard.kde.org/r/104036/diff/
> =

> =

> Testing
> -------
> =

> Recompiled after each removed public variable - are quite confident that =
I did not break anything.
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104036/">http://git.reviewboard.kde.org/r/104036/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 99c2f420bd6c0c0bac8fc7964ddeb5f150b23be3 by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On February 21st, 2012, 8:28 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Feb. 21, 2012, 8:28 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Rational: I want to have all options available as at least read-only to \
scripts.

For this Options need to inherit QObject and provide properties. For properties we \
need public getters instead of public access to the memeber variables. So this \
                changes:
* remove all public member variables and replace them by getters
* inherit QObject and export properties

Btw only one option was unused.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Recompiled after each removed public variable - are quite confident that \
I did not break anything.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/activation.cpp <span style="color: grey">(d954059)</span></li>

 <li>kwin/client.cpp <span style="color: grey">(34e9006)</span></li>

 <li>kwin/composite.cpp <span style="color: grey">(6a10d34)</span></li>

 <li>kwin/effects.cpp <span style="color: grey">(9602df3)</span></li>

 <li>kwin/events.cpp <span style="color: grey">(e249eca1)</span></li>

 <li>kwin/geometry.cpp <span style="color: grey">(b447838)</span></li>

 <li>kwin/layers.cpp <span style="color: grey">(397ff6f)</span></li>

 <li>kwin/manage.cpp <span style="color: grey">(e74c607)</span></li>

 <li>kwin/options.h <span style="color: grey">(67f2259)</span></li>

 <li>kwin/options.cpp <span style="color: grey">(f745ec4)</span></li>

 <li>kwin/placement.cpp <span style="color: grey">(1e6209c)</span></li>

 <li>kwin/scene_opengl.cpp <span style="color: grey">(f0971a2)</span></li>

 <li>kwin/scene_opengl_egl.cpp <span style="color: grey">(9868006)</span></li>

 <li>kwin/scene_opengl_glx.cpp <span style="color: grey">(1c6b235)</span></li>

 <li>kwin/scene_xrender.cpp <span style="color: grey">(9ff2db6)</span></li>

 <li>kwin/screenedge.cpp <span style="color: grey">(9734a1e)</span></li>

 <li>kwin/tabbox/tabbox.cpp <span style="color: grey">(3f26397)</span></li>

 <li>kwin/tiling/tiling.cpp <span style="color: grey">(5257284)</span></li>

 <li>kwin/tilinglayoutfactory.cpp <span style="color: grey">(78734e9)</span></li>

 <li>kwin/useractions.cpp <span style="color: grey">(1eaf3e2)</span></li>

 <li>kwin/workspace.cpp <span style="color: grey">(4f9ee18)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104036/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 