This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104036/

This review has been submitted with commit 99c2f420bd6c0c0bac8fc7964ddeb5f150b23be3 by Martin Gräßlin to branch master.

- Commit


On February 21st, 2012, 8:28 a.m., Martin Gräßlin wrote:

Review request for kwin.
By Martin Gräßlin.

Updated Feb. 21, 2012, 8:28 a.m.

Description

Rational: I want to have all options available as at least read-only to scripts.

For this Options need to inherit QObject and provide properties. For properties we need public getters instead of public access to the memeber variables. So this changes:
* remove all public member variables and replace them by getters
* inherit QObject and export properties

Btw only one option was unused.

Testing

Recompiled after each removed public variable - are quite confident that I did not break anything.

Diffs

  • kwin/activation.cpp (d954059)
  • kwin/client.cpp (34e9006)
  • kwin/composite.cpp (6a10d34)
  • kwin/effects.cpp (9602df3)
  • kwin/events.cpp (e249eca1)
  • kwin/geometry.cpp (b447838)
  • kwin/layers.cpp (397ff6f)
  • kwin/manage.cpp (e74c607)
  • kwin/options.h (67f2259)
  • kwin/options.cpp (f745ec4)
  • kwin/placement.cpp (1e6209c)
  • kwin/scene_opengl.cpp (f0971a2)
  • kwin/scene_opengl_egl.cpp (9868006)
  • kwin/scene_opengl_glx.cpp (1c6b235)
  • kwin/scene_xrender.cpp (9ff2db6)
  • kwin/screenedge.cpp (9734a1e)
  • kwin/tabbox/tabbox.cpp (3f26397)
  • kwin/tiling/tiling.cpp (5257284)
  • kwin/tilinglayoutfactory.cpp (78734e9)
  • kwin/useractions.cpp (1eaf3e2)
  • kwin/workspace.cpp (4f9ee18)

View Diff