'Review Request: Refactoring of KWin Options: add setters, change signals and default values'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: Refactoring of KWin Options: add setters, change signals and default values
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2012-04-12 18:24:35
Message-ID: 20120412182435.18156.75910 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104561/
-----------------------------------------------------------

Review request for kwin.

Description
-------

Adding setters for the various Options with a change signal for each single=
 option.

Code is rather straight forward and mostly auto-generated. Main reason I di=
d this change is for the next review I'll upload: I want to delay the loadi=
ng of the options and for that I need the object in a sane default state wi=
th initialized variables. Other nice thing is that it gives greater power t=
o scripts.

Diffs
-----

  kwin/options.h 855ed78 =

  kwin/options.cpp a250e79 =

Diff: http://git.reviewboard.kde.org/r/104561/diff/

Testing
-------

Thanks,

Martin Gr=C3=A4=C3=9Flin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104561/">http://git.reviewboard.kde.org/r/104561/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adding setters for the various Options with a change signal for each \
single option.

Code is rather straight forward and mostly auto-generated. Main reason I did this \
change is for the next review I&#39;ll upload: I want to delay the loading of the \
options and for that I need the object in a sane default state with initialized \
variables. Other nice thing is that it gives greater power to scripts.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/options.h <span style="color: grey">(855ed78)</span></li>

 <li>kwin/options.cpp <span style="color: grey">(a250e79)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104561/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 