From kwin Mon Feb 27 18:34:45 2012 From: "Commit Hook" Date: Mon, 27 Feb 2012 18:34:45 +0000 To: kwin Subject: Re: Review Request: Refactoring of KWin Options: turn it into a QObject and provide properties Message-Id: <20120227183445.1480.13851 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=133036773008323 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8722494119451288490==" --===============8722494119451288490== Content-Type: multipart/alternative; boundary="===============3429054167444549215==" --===============3429054167444549215== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104036/#review10962 ----------------------------------------------------------- This review has been submitted with commit 99c2f420bd6c0c0bac8fc7964ddeb5f1= 50b23be3 by Martin Gr=C3=A4=C3=9Flin to branch master. - Commit Hook On Feb. 21, 2012, 8:28 a.m., Martin Gr=C3=A4=C3=9Flin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104036/ > ----------------------------------------------------------- > = > (Updated Feb. 21, 2012, 8:28 a.m.) > = > = > Review request for kwin. > = > = > Description > ------- > = > Rational: I want to have all options available as at least read-only to s= cripts. > = > For this Options need to inherit QObject and provide properties. For prop= erties we need public getters instead of public access to the memeber varia= bles. So this changes: > * remove all public member variables and replace them by getters > * inherit QObject and export properties > = > Btw only one option was unused. > = > = > Diffs > ----- > = > kwin/activation.cpp d954059 = > kwin/client.cpp 34e9006 = > kwin/composite.cpp 6a10d34 = > kwin/effects.cpp 9602df3 = > kwin/events.cpp e249eca1 = > kwin/geometry.cpp b447838 = > kwin/layers.cpp 397ff6f = > kwin/manage.cpp e74c607 = > kwin/options.h 67f2259 = > kwin/options.cpp f745ec4 = > kwin/placement.cpp 1e6209c = > kwin/scene_opengl.cpp f0971a2 = > kwin/scene_opengl_egl.cpp 9868006 = > kwin/scene_opengl_glx.cpp 1c6b235 = > kwin/scene_xrender.cpp 9ff2db6 = > kwin/screenedge.cpp 9734a1e = > kwin/tabbox/tabbox.cpp 3f26397 = > kwin/tiling/tiling.cpp 5257284 = > kwin/tilinglayoutfactory.cpp 78734e9 = > kwin/useractions.cpp 1eaf3e2 = > kwin/workspace.cpp 4f9ee18 = > = > Diff: http://git.reviewboard.kde.org/r/104036/diff/ > = > = > Testing > ------- > = > Recompiled after each removed public variable - are quite confident that = I did not break anything. > = > = > Thanks, > = > Martin Gr=C3=A4=C3=9Flin > = > --===============3429054167444549215== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104036/

This revie=
w has been submitted with commit 99c2f420bd6c0c0bac8fc7964ddeb5f150b23be3 b=
y Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit

On February 21st, 2012, 8:28 a.m., Martin Gr=C3=A4=C3=9Flin wrote:

Review request for kwin.

By Martin Gr=C3=A4=C3=9Flin.

Updated Feb. 21, 2012, 8:28 a.m.

Descripti= on

Rational: I want to have all options available as at least r=
ead-only to scripts.

For this Options need to inherit QObject and provide properties. For proper=
ties we need public getters instead of public access to the memeber variabl=
es. So this changes:
* remove all public member variables and replace them by getters
* inherit QObject and export properties

Btw only one option was unused.

Testing <= /h1>

Recompiled after each removed public variable - are quite co=
nfident that I did not break anything.

Diffs=

kwin/activation.cpp (d954059)
kwin/client.cpp (34e9006)
kwin/composite.cpp (6a10d34)
kwin/effects.cpp (9602df3)
kwin/events.cpp (e249eca1)
kwin/geometry.cpp (b447838)
kwin/layers.cpp (397ff6f)
kwin/manage.cpp (e74c607)
kwin/options.h (67f2259)
kwin/options.cpp (f745ec4)
kwin/placement.cpp (1e6209c)
kwin/scene_opengl.cpp (f0971a2)
kwin/scene_opengl_egl.cpp (9868006)=
kwin/scene_opengl_glx.cpp (1c6b235)=
kwin/scene_xrender.cpp (9ff2db6)
kwin/screenedge.cpp (9734a1e)
kwin/tabbox/tabbox.cpp (3f26397)
kwin/tiling/tiling.cpp (5257284)
kwin/tilinglayoutfactory.cpp (78734e9)
kwin/useractions.cpp (1eaf3e2)
kwin/workspace.cpp (4f9ee18)

--===============3429054167444549215==-- --===============8722494119451288490== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============8722494119451288490==--