[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Change desktop size w/o restarting compositor
From: "Commit Hook" <null () kde ! org>
Date: 2012-01-24 21:27:47
Message-ID: 20120124212747.24062.5502 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103246/#review10056
-----------------------------------------------------------
This review has been submitted with commit 6ebf76dd5d80f4e4b33d604dd5862daa=
b42c5b06 by Thomas L=C3=BCbking to branch master.
- Commit Hook
On Nov. 26, 2011, 9:07 p.m., Thomas L=C3=BCbking wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103246/
> -----------------------------------------------------------
> =
> (Updated Nov. 26, 2011, 9:07 p.m.)
> =
> =
> Review request for kwin, Alex Fiestas and Martin Gr=C3=A4=C3=9Flin.
> =
> =
> Description
> -------
> =
> mostly a fix of martins approach which resized the overlay but not the ac=
tual buffer.
> plus, there was one more thing....
> =
> TODO: =
> - didn't implement the buffer update for the non overlay case (means to k=
ick the buffer pix and create a new, no big deal but i'm f**** lazy :-)
> - implementing/testing GLES, the buffer resize should not be necessary...=
the other thing probably should
> =
> =
> Diffs
> -----
> =
> kwin/effects.h 6530871 =
> kwin/effects.cpp 000e35c =
> kwin/effects/blur/blur.h 313f311 =
> kwin/effects/blur/blur.cpp c566e34 =
> kwin/geometry.cpp 69eb566 =
> kwin/libkwineffects/kwineffects.h 780cc89 =
> kwin/libkwineffects/kwinglutils.h 876cf3a =
> kwin/libkwineffects/kwinglutils.cpp 7e51bc9 =
> kwin/overlaywindow.h 14d2d58 =
> kwin/overlaywindow.cpp 43f1a52 =
> kwin/scene.h d8bcf48 =
> kwin/scene.cpp 81ca937 =
> kwin/scene_opengl.h e13d8a5 =
> kwin/scene_opengl_egl.cpp 22e082c =
> kwin/scene_opengl_glx.cpp ddebcd0 =
> kwin/scene_xrender.h 6c916c8 =
> kwin/scene_xrender.cpp f0a775c =
> =
> Diff: http://git.reviewboard.kde.org/r/103246/diff/diff
> =
> =
> Testing
> -------
> =
> yupp
> =
> =
> Thanks,
> =
> Thomas L=C3=BCbking
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103246/">http://git.reviewboard.kde.org/r/103246/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 6ebf76dd5d80f4e4b33d604dd5862daab42c5b06 by Thomas Lübking to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On November 26th, 2011, 9:07 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Alex Fiestas and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Nov. 26, 2011, 9:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">mostly a fix of martins approach which resized the overlay but not the \
actual buffer. plus, there was one more thing....
TODO:
- didn't implement the buffer update for the non overlay case (means to kick the \
buffer pix and create a new, no big deal but i'm f**** lazy :-)
- implementing/testing GLES, the buffer resize should not be necessary... the other \
thing probably should </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yupp</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects.h <span style="color: grey">(6530871)</span></li>
<li>kwin/effects.cpp <span style="color: grey">(000e35c)</span></li>
<li>kwin/effects/blur/blur.h <span style="color: grey">(313f311)</span></li>
<li>kwin/effects/blur/blur.cpp <span style="color: grey">(c566e34)</span></li>
<li>kwin/geometry.cpp <span style="color: grey">(69eb566)</span></li>
<li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(780cc89)</span></li>
<li>kwin/libkwineffects/kwinglutils.h <span style="color: \
grey">(876cf3a)</span></li>
<li>kwin/libkwineffects/kwinglutils.cpp <span style="color: \
grey">(7e51bc9)</span></li>
<li>kwin/overlaywindow.h <span style="color: grey">(14d2d58)</span></li>
<li>kwin/overlaywindow.cpp <span style="color: grey">(43f1a52)</span></li>
<li>kwin/scene.h <span style="color: grey">(d8bcf48)</span></li>
<li>kwin/scene.cpp <span style="color: grey">(81ca937)</span></li>
<li>kwin/scene_opengl.h <span style="color: grey">(e13d8a5)</span></li>
<li>kwin/scene_opengl_egl.cpp <span style="color: grey">(22e082c)</span></li>
<li>kwin/scene_opengl_glx.cpp <span style="color: grey">(ddebcd0)</span></li>
<li>kwin/scene_xrender.h <span style="color: grey">(6c916c8)</span></li>
<li>kwin/scene_xrender.cpp <span style="color: grey">(f0a775c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103246/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic