This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103246/

This review has been submitted with commit 6ebf76dd5d80f4e4b33d604dd5862daab42c5b06 by Thomas Lübking to branch master.

- Commit


On November 26th, 2011, 9:07 p.m., Thomas Lübking wrote:

Review request for kwin, Alex Fiestas and Martin Gräßlin.
By Thomas Lübking.

Updated Nov. 26, 2011, 9:07 p.m.

Description

mostly a fix of martins approach which resized the overlay but not the actual buffer.
plus, there was one more thing....

TODO: 
- didn't implement the buffer update for the non overlay case (means to kick the buffer pix and create a new, no big deal but i'm f**** lazy :-)
- implementing/testing GLES, the buffer resize should not be necessary... the other thing probably should

Testing

yupp

Diffs

  • kwin/effects.h (6530871)
  • kwin/effects.cpp (000e35c)
  • kwin/effects/blur/blur.h (313f311)
  • kwin/effects/blur/blur.cpp (c566e34)
  • kwin/geometry.cpp (69eb566)
  • kwin/libkwineffects/kwineffects.h (780cc89)
  • kwin/libkwineffects/kwinglutils.h (876cf3a)
  • kwin/libkwineffects/kwinglutils.cpp (7e51bc9)
  • kwin/overlaywindow.h (14d2d58)
  • kwin/overlaywindow.cpp (43f1a52)
  • kwin/scene.h (d8bcf48)
  • kwin/scene.cpp (81ca937)
  • kwin/scene_opengl.h (e13d8a5)
  • kwin/scene_opengl_egl.cpp (22e082c)
  • kwin/scene_opengl_glx.cpp (ddebcd0)
  • kwin/scene_xrender.h (6c916c8)
  • kwin/scene_xrender.cpp (f0a775c)

View Diff