[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: working animations in diminactive
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-01-24 19:12:03
Message-ID: 20120124191203.7832.29967 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 11, 2012, 3:59 p.m., Thomas L=C3=BCbking wrote:
> > There's a gap when switching windows, but it should be covered in the c=
ore, not the effects (it's as well for the decoration or so)
> > However, if this: "mTimelines[ w ]" re-enters kwin effects, i go on str=
ike*! ;-)
> > =
> > Please have a look at the AnimationEffect class, the general idea is to=
rebase such effects there.(while i'm currently not sure about the requirem=
ent of independent animation speeds in this case)
> > =
> > *About the QHash::operator[] usage: DON'T USE IT. EVER: (unless you rea=
lly want to ;-)
> > Not because it's bad by itself, but because it triggers false usage (an=
access to a non-existing element silently adds it, preventing segfaults, b=
ut causing non deterministic behavior. We had MUCH trouble with that. Also =
it's horribly imperformant, since it not only does a hash lookup but also c=
opies the hash structure for a "detach()")
> > =
> > Yes, couple of effects still have it, but it's also been removed from m=
ost of them.
Yes I quite agree on not using [] in effects anymore. I think this will be =
a nice effect to try my not yet written JS bindings for effects :-P
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103676/#review9750
-----------------------------------------------------------
On Jan. 11, 2012, 3:37 p.m., Marco Martin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103676/
> -----------------------------------------------------------
> =
> (Updated Jan. 11, 2012, 3:37 p.m.)
> =
> =
> Review request for kwin.
> =
> =
> Description
> -------
> =
> use a different timeline for each window, letting for independent fade an=
imations (needed when the active window switches quickly).
> =
> issue found:
> windowActivated() is emitted two times on each window switch, making the =
effect believe there is no active window for a moment, breaking the dim/hig=
hlight of window groups.
> is it an intended behavior?
> only way around i know is doing event compression for that signal, so we =
react only to the final coherent state.
> =
> =
> Diffs
> -----
> =
> kwin/effects/diminactive/diminactive.h 24a80de =
> kwin/effects/diminactive/diminactive.cpp 6978f36 =
> =
> Diff: http://git.reviewboard.kde.org/r/103676/diff/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Marco Martin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103676/">http://git.reviewboard.kde.org/r/103676/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 11th, 2012, 3:59 p.m., <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There's a gap when switching windows, but it should be covered in \
the core, not the effects (it's as well for the decoration or so) However, if \
this: "mTimelines[ w ]" re-enters kwin effects, i go on strike*! ;-)
Please have a look at the AnimationEffect class, the general idea is to rebase such \
effects there.(while i'm currently not sure about the requirement of independent \
animation speeds in this case)
*About the QHash::operator[] usage: DON'T USE IT. EVER: (unless you really want \
to ;-) Not because it's bad by itself, but because it triggers false usage (an \
access to a non-existing element silently adds it, preventing segfaults, but causing \
non deterministic behavior. We had MUCH trouble with that. Also it's horribly \
imperformant, since it not only does a hash lookup but also copies the hash structure \
for a "detach()")
Yes, couple of effects still have it, but it's also been removed from most of \
them.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes I quite agree on not \
using [] in effects anymore. I think this will be a nice effect to try my not yet \
written JS bindings for effects :-P</pre> <br />
<p>- Martin</p>
<br />
<p>On January 11th, 2012, 3:37 p.m., Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Jan. 11, 2012, 3:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">use a different timeline for each window, letting for independent fade \
animations (needed when the active window switches quickly).
issue found:
windowActivated() is emitted two times on each window switch, making the effect \
believe there is no active window for a moment, breaking the dim/highlight of window \
groups. is it an intended behavior?
only way around i know is doing event compression for that signal, so we react only \
to the final coherent state. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/diminactive/diminactive.h <span style="color: \
grey">(24a80de)</span></li>
<li>kwin/effects/diminactive/diminactive.cpp <span style="color: \
grey">(6978f36)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103676/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic