[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Swap vsync order, trade in 1frame lag, try harder to detect nvidia framerate (re
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-01-24 21:48:19
Message-ID: 20120124214819.27247.17148 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 24, 2012, 7:09 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> > Is this one committed?
Nope. Neither the actual swap, nor the nvidia framerate selection.
For the latter, i shall have a look on XFree86-VidModeExtension, for the fo=
rmer - maybe we can actually move the gl renderer into its own thread if we=
rely on Qt4.8 (waiting alongside a mutex for the next sync, when the mutex=
is open -> render. Otherwise skip that frame.)?
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103058/#review10051
-----------------------------------------------------------
On Nov. 10, 2011, 4:30 p.m., Thomas L=C3=BCbking wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103058/
> -----------------------------------------------------------
> =
> (Updated Nov. 10, 2011, 4:30 p.m.)
> =
> =
> Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
> =
> =
> Description
> -------
> =
> This performs a paint & glFlush immediately after the buffer swapping and=
defers the next swapping to the next anticipated frame (or idling)
> The behavior is still not as deterministic as we hoped to be since we can=
not measure the time for the actual vsync :\
> I set a fuzzyness of 6ms what leads to a majority of 2-3ms times in waits=
ync but single wait times up to 8 or 9ms occur (what ultimately can be part=
of the syncing itself)
> =
> There's some debug code to print lagging.
> =
> TODO:
> - attempt egl support
> - probably lie to the effects about the time
> =
> =
> Diffs
> -----
> =
> kwin/composite.cpp aa721b8 =
> kwin/options.cpp 19c3ee5 =
> kwin/scene.h d8bcf48 =
> kwin/scene.cpp 413e46f =
> kwin/scene_basic.h a087eb5 =
> kwin/scene_basic.cpp cc8dbdd =
> kwin/scene_opengl.h e13d8a5 =
> kwin/scene_opengl.cpp 47015b3 =
> kwin/scene_opengl_egl.cpp 22e082c =
> kwin/scene_opengl_glx.cpp ddebcd0 =
> kwin/scene_xrender.h 6c916c8 =
> kwin/scene_xrender.cpp 3618d79 =
> kwin/workspace.h 4d7fda5 =
> kwin/workspace.cpp 6a8e2df =
> =
> Diff: http://git.reviewboard.kde.org/r/103058/diff/diff
> =
> =
> Testing
> -------
> =
> I've used a CRT for testing which can sync every 11ms ie. 85Hz and lowere=
d the maxFPS down to 10fps with pretty constant results for the time lost w=
aiting for the sync.
> =
> =
> Thanks,
> =
> Thomas L=C3=BCbking
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103058/">http://git.reviewboard.kde.org/r/103058/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 24th, 2012, 7:09 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Is this one committed?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nope. Neither the actual \
swap, nor the nvidia framerate selection. For the latter, i shall have a look on \
XFree86-VidModeExtension, for the former - maybe we can actually move the gl renderer \
into its own thread if we rely on Qt4.8 (waiting alongside a mutex for the next sync, \
when the mutex is open -> render. Otherwise skip that frame.)?</pre> <br />
<p>- Thomas</p>
<br />
<p>On November 10th, 2011, 4:30 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2011, 4:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This performs a paint & glFlush immediately after the buffer \
swapping and defers the next swapping to the next anticipated frame (or idling) The \
behavior is still not as deterministic as we hoped to be since we cannot measure the \
time for the actual vsync :\ I set a fuzzyness of 6ms what leads to a majority of \
2-3ms times in waitsync but single wait times up to 8 or 9ms occur (what ultimately \
can be part of the syncing itself)
There's some debug code to print lagging.
TODO:
- attempt egl support
- probably lie to the effects about the time</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I've used a CRT for testing which can sync every 11ms ie. 85Hz and \
lowered the maxFPS down to 10fps with pretty constant results for the time lost \
waiting for the sync.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/composite.cpp <span style="color: grey">(aa721b8)</span></li>
<li>kwin/options.cpp <span style="color: grey">(19c3ee5)</span></li>
<li>kwin/scene.h <span style="color: grey">(d8bcf48)</span></li>
<li>kwin/scene.cpp <span style="color: grey">(413e46f)</span></li>
<li>kwin/scene_basic.h <span style="color: grey">(a087eb5)</span></li>
<li>kwin/scene_basic.cpp <span style="color: grey">(cc8dbdd)</span></li>
<li>kwin/scene_opengl.h <span style="color: grey">(e13d8a5)</span></li>
<li>kwin/scene_opengl.cpp <span style="color: grey">(47015b3)</span></li>
<li>kwin/scene_opengl_egl.cpp <span style="color: grey">(22e082c)</span></li>
<li>kwin/scene_opengl_glx.cpp <span style="color: grey">(ddebcd0)</span></li>
<li>kwin/scene_xrender.h <span style="color: grey">(6c916c8)</span></li>
<li>kwin/scene_xrender.cpp <span style="color: grey">(3618d79)</span></li>
<li>kwin/workspace.h <span style="color: grey">(4d7fda5)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(6a8e2df)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103058/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic