[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Delay added signal and other signal bindings for synced windows until the window
From: "Philipp Knechtges" <philipp-dev () knechtges ! com>
Date: 2012-01-21 17:19:30
Message-ID: 20120121171930.4028.69831 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103742/#review9984
-----------------------------------------------------------
Although I agree with you that the effects shouldn't be bothered with a win=
dow that isn't shown once,
I would prefer to make the emitted signals consistent. Your current approac=
h has the shortcoming that
it might not emit the windowAdded signal, but on the other hand it would al=
ways emit windowClosed
and windowDeleted.
- Philipp Knechtges
On Jan. 20, 2012, 2:21 a.m., Thomas L=C3=BCbking wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103742/
> -----------------------------------------------------------
> =
> (Updated Jan. 20, 2012, 2:21 a.m.)
> =
> =
> Review request for kwin, Martin Gr=C3=A4=C3=9Flin and Philipp Knechtges.
> =
> =
> Description
> -------
> =
> see summary. Makes animations smoother and would have prevented RR http:/=
/git.reviewboard.kde.org/r/103733 ;-)
> =
> I'll keep it in my personal 4.8 branch and therefore won't care about whe=
ther it's applied to 4.8.n or 4.9 :-P
> =
> =
> Diffs
> -----
> =
> kwin/client.cpp 520ed85 =
> kwin/composite.cpp 55a7144 =
> kwin/effects.h f4ad2fb =
> kwin/effects.cpp 6c252c9 =
> kwin/events.cpp 26e0139 =
> kwin/toplevel.h 693e6f3 =
> kwin/toplevel.cpp ffe7f0c =
> =
> Diff: http://git.reviewboard.kde.org/r/103742/diff/diff
> =
> =
> Testing
> -------
> =
> generic animations still work - better ;-)
> =
> =
> Thanks,
> =
> Thomas L=C3=BCbking
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103742/">http://git.reviewboard.kde.org/r/103742/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Although I agree with \
you that the effects shouldn't be bothered with a window that isn't shown \
once, I would prefer to make the emitted signals consistent. Your current approach \
has the shortcoming that it might not emit the windowAdded signal, but on the other \
hand it would always emit windowClosed and windowDeleted.</pre>
<br />
<p>- Philipp</p>
<br />
<p>On January 20th, 2012, 2:21 a.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin and Philipp Knechtges.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2012, 2:21 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">see summary. Makes animations smoother and would have prevented RR \
http://git.reviewboard.kde.org/r/103733 ;-)
I'll keep it in my personal 4.8 branch and therefore won't care about whether \
it's applied to 4.8.n or 4.9 :-P</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">generic animations still work - better ;-)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/client.cpp <span style="color: grey">(520ed85)</span></li>
<li>kwin/composite.cpp <span style="color: grey">(55a7144)</span></li>
<li>kwin/effects.h <span style="color: grey">(f4ad2fb)</span></li>
<li>kwin/effects.cpp <span style="color: grey">(6c252c9)</span></li>
<li>kwin/events.cpp <span style="color: grey">(26e0139)</span></li>
<li>kwin/toplevel.h <span style="color: grey">(693e6f3)</span></li>
<li>kwin/toplevel.cpp <span style="color: grey">(ffe7f0c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103742/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic