'Re: Review Request: Delay added signal and other signal bindings for synced windows until the window'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Delay added signal and other signal bindings for synced windows until the window
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-01-20 2:21:57
Message-ID: 20120120022157.15360.88210 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103742/
-----------------------------------------------------------

(Updated Jan. 20, 2012, 2:21 a.m.)

Review request for kwin, Martin Gr=C3=A4=C3=9Flin and Philipp Knechtges.

Changes
-------

Forgot that the damageEvent is the only trigger for clients not supporting =
the XSYNC extension ...

Description
-------

see summary. Makes animations smoother and would have prevented RR http://g=
it.reviewboard.kde.org/r/103733 ;-)

I'll keep it in my personal 4.8 branch and therefore won't care about wheth=
er it's applied to 4.8.n or 4.9 :-P

Diffs (updated)
-----

  kwin/client.cpp 520ed85 =

  kwin/composite.cpp 55a7144 =

  kwin/effects.h f4ad2fb =

  kwin/effects.cpp 6c252c9 =

  kwin/events.cpp 26e0139 =

  kwin/toplevel.h 693e6f3 =

  kwin/toplevel.cpp ffe7f0c =

Diff: http://git.reviewboard.kde.org/r/103742/diff/diff

Testing
-------

generic animations still work - better ;-)

Thanks,

Thomas L=C3=BCbking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103742/">http://git.reviewboard.kde.org/r/103742/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Martin Gräßlin and Philipp Knechtges.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Jan. 20, 2012, 2:21 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Forgot that the damageEvent is the only trigger for clients not \
supporting the XSYNC extension ...</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">see summary. Makes animations smoother and would have prevented RR \
http://git.reviewboard.kde.org/r/103733 ;-)

I&#39;ll keep it in my personal 4.8 branch and therefore won&#39;t care about whether \
it&#39;s applied to 4.8.n or 4.9 :-P</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">generic animations still work - better ;-)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/client.cpp <span style="color: grey">(520ed85)</span></li>

 <li>kwin/composite.cpp <span style="color: grey">(55a7144)</span></li>

 <li>kwin/effects.h <span style="color: grey">(f4ad2fb)</span></li>

 <li>kwin/effects.cpp <span style="color: grey">(6c252c9)</span></li>

 <li>kwin/events.cpp <span style="color: grey">(26e0139)</span></li>

 <li>kwin/toplevel.h <span style="color: grey">(693e6f3)</span></li>

 <li>kwin/toplevel.cpp <span style="color: grey">(ffe7f0c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103742/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 