This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103742/ |
Although I agree with you that the effects shouldn't be bothered with a window that isn't shown once, I would prefer to make the emitted signals consistent. Your current approach has the shortcoming that it might not emit the windowAdded signal, but on the other hand it would always emit windowClosed and windowDeleted.
- Philipp
On January 20th, 2012, 2:21 a.m., Thomas Lübking wrote:
Review request for kwin, Martin Gräßlin and Philipp Knechtges.
By Thomas Lübking.
Updated Jan. 20, 2012, 2:21 a.m. Description
Testing
Diffs
|