This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103742/

Although I agree with you that the effects shouldn't be bothered with a window that isn't shown once,
I would prefer to make the emitted signals consistent. Your current approach has the shortcoming that
it might not emit the windowAdded signal, but on the other hand it would always emit windowClosed
and windowDeleted.

- Philipp


On January 20th, 2012, 2:21 a.m., Thomas Lübking wrote:

Review request for kwin, Martin Gräßlin and Philipp Knechtges.
By Thomas Lübking.

Updated Jan. 20, 2012, 2:21 a.m.

Description

see summary. Makes animations smoother and would have prevented RR http://git.reviewboard.kde.org/r/103733 ;-)

I'll keep it in my personal 4.8 branch and therefore won't care about whether it's applied to 4.8.n or 4.9 :-P

Testing

generic animations still work - better ;-)

Diffs

  • kwin/client.cpp (520ed85)
  • kwin/composite.cpp (55a7144)
  • kwin/effects.h (f4ad2fb)
  • kwin/effects.cpp (6c252c9)
  • kwin/events.cpp (26e0139)
  • kwin/toplevel.h (693e6f3)
  • kwin/toplevel.cpp (ffe7f0c)

View Diff