From kwin Sat Jan 21 17:19:30 2012 From: "Philipp Knechtges" Date: Sat, 21 Jan 2012 17:19:30 +0000 To: kwin Subject: Re: Review Request: Delay added signal and other signal bindings for synced windows until the window Message-Id: <20120121171930.4028.69831 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=132716655404928 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7233202069666605233==" --===============7233202069666605233== Content-Type: multipart/alternative; boundary="===============3478551543738583856==" --===============3478551543738583856== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103742/#review9984 ----------------------------------------------------------- Although I agree with you that the effects shouldn't be bothered with a win= dow that isn't shown once, I would prefer to make the emitted signals consistent. Your current approac= h has the shortcoming that it might not emit the windowAdded signal, but on the other hand it would al= ways emit windowClosed and windowDeleted. - Philipp Knechtges On Jan. 20, 2012, 2:21 a.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103742/ > ----------------------------------------------------------- > = > (Updated Jan. 20, 2012, 2:21 a.m.) > = > = > Review request for kwin, Martin Gr=C3=A4=C3=9Flin and Philipp Knechtges. > = > = > Description > ------- > = > see summary. Makes animations smoother and would have prevented RR http:/= /git.reviewboard.kde.org/r/103733 ;-) > = > I'll keep it in my personal 4.8 branch and therefore won't care about whe= ther it's applied to 4.8.n or 4.9 :-P > = > = > Diffs > ----- > = > kwin/client.cpp 520ed85 = > kwin/composite.cpp 55a7144 = > kwin/effects.h f4ad2fb = > kwin/effects.cpp 6c252c9 = > kwin/events.cpp 26e0139 = > kwin/toplevel.h 693e6f3 = > kwin/toplevel.cpp ffe7f0c = > = > Diff: http://git.reviewboard.kde.org/r/103742/diff/diff > = > = > Testing > ------- > = > generic animations still work - better ;-) > = > = > Thanks, > = > Thomas L=C3=BCbking > = > --===============3478551543738583856== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103742/ 

Although I=
 agree with you that the effects shouldn't be bothered with a window th=
at isn't shown once,
I would prefer to make the emitted signals consistent. Your current approac=
h has the shortcoming that
it might not emit the windowAdded signal, but on the other hand it would al=
ways emit windowClosed
and windowDeleted.

- Philipp


On January 20th, 2012, 2:21 a.m., Thomas L=C3=BCbking wrote:

Review request for kwin, Martin Gr=C3=A4=C3=9Flin and Philipp Knechtge= s.
By Thomas L=C3=BCbking.

Updated Jan. 20, 2012, 2:21 a.m.

Descripti= on 

see summary. Makes animations smoother and would have preven=
ted RR http://git.reviewboard.kde.org/r/103733 ;-)

I'll keep it in my personal 4.8 branch and therefore won't care abo=
ut whether it's applied to 4.8.n or 4.9 :-P

Testing <= /h1> 
generic animations still work - better ;-)

Diffs=

  • kwin/client.cpp (520ed85)
  • kwin/composite.cpp (55a7144)
  • kwin/effects.h (f4ad2fb)
  • kwin/effects.cpp (6c252c9)
  • kwin/events.cpp (26e0139)
  • kwin/toplevel.h (693e6f3)
  • kwin/toplevel.cpp (ffe7f0c)

View Diff
--===============3478551543738583856==-- --===============7233202069666605233== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============7233202069666605233==--