'Re: Review Request: Add Support for Framebuffer Blit extension to'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Add Support for Framebuffer Blit extension to
From:       "Commit Hook" <null () kde ! org>
Date:       2011-08-20 8:59:20
Message-ID: 20110820085920.7971.4710 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102354/#review5841
-----------------------------------------------------------

This review has been submitted with commit c8ddc9710356f385c4291a25d5a629d6=
1f7d4201 by Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit

On Aug. 17, 2011, 5:38 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102354/
> -----------------------------------------------------------
> =

> (Updated Aug. 17, 2011, 5:38 p.m.)
> =

> =

> Review request for kwin.
> =

> =

> Summary
> -------
> =

> * resolves functions for framebuffer blit
> * adds a convenient method to blit content of current framebuffer into a =
texture attached to FBO
> * demonstration usage code added to screenshot effect
> =

> Why do we need it?
> * I want to use it in the new magnifier effect
> * I hope framebuffer blit could be used to copy buffers for non-fullscree=
n and NVIDIA (will write a small benchmark)
> * I hope it could improve performance for blur and/or lanczos filter (wil=
l write a small benchmark)
> =

> =

> Diffs
> -----
> =

>   kwin/effects/screenshot/screenshot.h 83b29a8 =

>   kwin/effects/screenshot/screenshot.cpp e1704b4 =

>   kwin/libkwineffects/kwinglutils.h 6a0a7f9 =

>   kwin/libkwineffects/kwinglutils.cpp 19b4ebb =

>   kwin/libkwineffects/kwinglutils_funcs.h 45df4d5 =

>   kwin/libkwineffects/kwinglutils_funcs.cpp d935a7f =

> =

> Diff: http://git.reviewboard.kde.org/r/102354/diff
> =

> =

> Testing
> -------
> =

> screenshots work
> =

> =

> Thanks,
> =

> Martin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102354/">http://git.reviewboard.kde.org/r/102354/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit c8ddc9710356f385c4291a25d5a629d61f7d4201 by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On August 17th, 2011, 5:38 p.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Aug. 17, 2011, 5:38 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">* resolves functions for framebuffer blit
* adds a convenient method to blit content of current framebuffer into a texture \
                attached to FBO
* demonstration usage code added to screenshot effect

Why do we need it?
* I want to use it in the new magnifier effect
* I hope framebuffer blit could be used to copy buffers for non-fullscreen and NVIDIA \
                (will write a small benchmark)
* I hope it could improve performance for blur and/or lanczos filter (will write a \
small benchmark)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">screenshots work</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/screenshot/screenshot.h <span style="color: \
grey">(83b29a8)</span></li>

 <li>kwin/effects/screenshot/screenshot.cpp <span style="color: \
grey">(e1704b4)</span></li>

 <li>kwin/libkwineffects/kwinglutils.h <span style="color: \
grey">(6a0a7f9)</span></li>

 <li>kwin/libkwineffects/kwinglutils.cpp <span style="color: \
grey">(19b4ebb)</span></li>

 <li>kwin/libkwineffects/kwinglutils_funcs.h <span style="color: \
grey">(45df4d5)</span></li>

 <li>kwin/libkwineffects/kwinglutils_funcs.cpp <span style="color: \
grey">(d935a7f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102354/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 