[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Lower/Raise window opacity with modifier+mouse
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2011-08-20 11:36:22
Message-ID: 20110820113622.17156.77846 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102377/#review5850
-----------------------------------------------------------
kwin/kcmkwin/kwinoptions/mouse.cpp
<http://git.reviewboard.kde.org/r/102377/#comment5179>
Maybe use "Decrease Opacity". First because it matches "Increase" bette=
r, second because it could be confused with "Lower" above ("I can change th=
e opacity for windows in the background?")
- Christoph
On Aug. 19, 2011, 8:51 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102377/
> -----------------------------------------------------------
> =
> (Updated Aug. 19, 2011, 8:51 p.m.)
> =
> =
> Review request for kwin and Christoph Feck.
> =
> =
> Summary
> -------
> =
> And the third patch to implement the modifier + lmb/rmb as Thomas suggest=
ed.
> =
> =
> Diffs
> -----
> =
> kwin/kcmkwin/kwinoptions/mouse.cpp 41e0e94 =
> kwin/options.cpp 6522e44 =
> =
> Diff: http://git.reviewboard.kde.org/r/102377/diff
> =
> =
> Testing
> -------
> =
> works as expected
> =
> =
> Thanks,
> =
> Martin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102377/">http://git.reviewboard.kde.org/r/102377/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/102377/diff/1/?file=32187#file32187line492" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/kcmkwin/kwinoptions/mouse.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">const \
char* const tbl_All[] = {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">492</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">"Lower Opacity"</span><span class="p">,</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe use \
"Decrease Opacity". First because it matches "Increase" better, \
second because it could be confused with "Lower" above ("I can change \
the opacity for windows in the background?")</pre> </div>
<br />
<p>- Christoph</p>
<br />
<p>On August 19th, 2011, 8:51 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Christoph Feck.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Aug. 19, 2011, 8:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">And the third patch to implement the modifier + lmb/rmb as Thomas \
suggested.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works as expected</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/kcmkwin/kwinoptions/mouse.cpp <span style="color: \
grey">(41e0e94)</span></li>
<li>kwin/options.cpp <span style="color: grey">(6522e44)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102377/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic