--===============4659926462751363217== Content-Type: multipart/alternative; boundary="===============1962108803037000094==" --===============1962108803037000094== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102354/#review5841 ----------------------------------------------------------- This review has been submitted with commit c8ddc9710356f385c4291a25d5a629d6= 1f7d4201 by Martin Gr=C3=A4=C3=9Flin to branch master. - Commit On Aug. 17, 2011, 5:38 p.m., Martin Gr=C3=A4=C3=9Flin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102354/ > ----------------------------------------------------------- > = > (Updated Aug. 17, 2011, 5:38 p.m.) > = > = > Review request for kwin. > = > = > Summary > ------- > = > * resolves functions for framebuffer blit > * adds a convenient method to blit content of current framebuffer into a = texture attached to FBO > * demonstration usage code added to screenshot effect > = > Why do we need it? > * I want to use it in the new magnifier effect > * I hope framebuffer blit could be used to copy buffers for non-fullscree= n and NVIDIA (will write a small benchmark) > * I hope it could improve performance for blur and/or lanczos filter (wil= l write a small benchmark) > = > = > Diffs > ----- > = > kwin/effects/screenshot/screenshot.h 83b29a8 = > kwin/effects/screenshot/screenshot.cpp e1704b4 = > kwin/libkwineffects/kwinglutils.h 6a0a7f9 = > kwin/libkwineffects/kwinglutils.cpp 19b4ebb = > kwin/libkwineffects/kwinglutils_funcs.h 45df4d5 = > kwin/libkwineffects/kwinglutils_funcs.cpp d935a7f = > = > Diff: http://git.reviewboard.kde.org/r/102354/diff > = > = > Testing > ------- > = > screenshots work > = > = > Thanks, > = > Martin > = > --===============1962108803037000094== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102354/ 

This revie=
w has been submitted with commit c8ddc9710356f385c4291a25d5a629d61f7d4201 b=
y Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit


On August 17th, 2011, 5:38 p.m., Martin Gr=C3=A4=C3=9Flin wrote:

Review request for kwin.
By Martin Gr=C3=A4=C3=9Flin.

Updated Aug. 17, 2011, 5:38 p.m.

Descripti= on 

* resolves functions for framebuffer blit
* adds a convenient method to blit content of current framebuffer into a te=
xture attached to FBO
* demonstration usage code added to screenshot effect

Why do we need it?
* I want to use it in the new magnifier effect
* I hope framebuffer blit could be used to copy buffers for non-fullscreen =
and NVIDIA (will write a small benchmark)
* I hope it could improve performance for blur and/or lanczos filter (will =
write a small benchmark)

Testing <= /h1> 
screenshots work

Diffs=

  • kwin/effects/screenshot/screenshot.h (83b2= 9a8)
  • kwin/effects/screenshot/screenshot.cpp (e1= 704b4)
  • kwin/libkwineffects/kwinglutils.h (6a0a7f9= )
  • kwin/libkwineffects/kwinglutils.cpp (19b4e= bb)
  • kwin/libkwineffects/kwinglutils_funcs.h (4= 5df4d5)
  • kwin/libkwineffects/kwinglutils_funcs.cpp = (d935a7f)

View Diff
--===============1962108803037000094==-- --===============4659926462751363217== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============4659926462751363217==--