This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102354/

This review has been submitted with commit c8ddc9710356f385c4291a25d5a629d61f7d4201 by Martin Gräßlin to branch master.

- Commit


On August 17th, 2011, 5:38 p.m., Martin Gräßlin wrote:

Review request for kwin.
By Martin Gräßlin.

Updated Aug. 17, 2011, 5:38 p.m.

Description

* resolves functions for framebuffer blit
* adds a convenient method to blit content of current framebuffer into a texture attached to FBO
* demonstration usage code added to screenshot effect

Why do we need it?
* I want to use it in the new magnifier effect
* I hope framebuffer blit could be used to copy buffers for non-fullscreen and NVIDIA (will write a small benchmark)
* I hope it could improve performance for blur and/or lanczos filter (will write a small benchmark)

Testing

screenshots work

Diffs

  • kwin/effects/screenshot/screenshot.h (83b29a8)
  • kwin/effects/screenshot/screenshot.cpp (e1704b4)
  • kwin/libkwineffects/kwinglutils.h (6a0a7f9)
  • kwin/libkwineffects/kwinglutils.cpp (19b4ebb)
  • kwin/libkwineffects/kwinglutils_funcs.h (45df4d5)
  • kwin/libkwineffects/kwinglutils_funcs.cpp (d935a7f)

View Diff