[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Fix dialogparent implementation
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2011-03-19 15:38:18
Message-ID: 20110319153818.7853.23214 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 19, 2011, 6:30 a.m., Martin Gräßlin wrote:
> > please push to both master and KDE/4.6.
done, slightly adjusted for master (cause of signal/slot infrastructure)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100887/#review2042
-----------------------------------------------------------
On March 18, 2011, 10:43 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100887/
> -----------------------------------------------------------
>
> (Updated March 18, 2011, 10:43 p.m.)
>
>
> Review request for kwin.
>
>
> Summary
> -------
>
> Rewrite.
> a) use QMap instead of QHash because of
> b) don't keep every client but only (temporarily) the relevant ones (typically << \
> 10) and therefore c) don't leak
> d) the bloody QHash:operator[] should yell a compiler "#warning WRONG!" ;-P
> e) i raised the anim time from 200 -> 300, matter of personal taste though (it's \
> esp. about fade out, because there's also another client appearing -animatedly- \
> pot. sucking cpu anyway, thus blocking updates for a short while)
> ---
> > > I vote for an exceptional backport to branch despite it's a big patch.
> > > It's only a tiny effect & little code and whatever regression i wrote into it - \
> > > i cannot be worse ;-P
> > > (patch is for branch, i'd just copy the file over to master then. ws should be \
> > > ok - hopefully...)
>
>
> This addresses bug 267349.
> http://bugs.kde.org/show_bug.cgi?id=267349
>
>
> Diffs
> -----
>
> kwin/effects/dialogparent/dialogparent.h 08eef03
> kwin/effects/dialogparent/dialogparent.cpp cc663aa
>
> Diff: http://git.reviewboard.kde.org/r/100887/diff
>
>
> Testing
> -------
>
> Yes. See QtDebug include in the first version :-)
>
>
> Thanks,
>
> Thomas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100887/">http://git.reviewboard.kde.org/r/100887/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 19th, 2011, 6:30 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">please push to both master and KDE/4.6.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">done, slightly adjusted \
for master (cause of signal/slot infrastructure)</pre> <br />
<p>- Thomas</p>
<br />
<p>On March 18th, 2011, 10:43 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated March 18, 2011, 10:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Rewrite. a) use QMap instead of QHash because of
b) don't keep every client but only (temporarily) the relevant ones (typically \
<< 10) and therefore c) don't leak
d) the bloody QHash:operator[] should yell a compiler "#warning WRONG!" ;-P
e) i raised the anim time from 200 -> 300, matter of personal taste though \
(it's esp. about fade out, because there's also another client appearing \
-animatedly- pot. sucking cpu anyway, thus blocking updates for a short while)
---
> > I vote for an exceptional backport to branch despite it's a big patch.
> > It's only a tiny effect & little code and whatever regression i wrote \
> > into it - i cannot be worse ;-P
> > (patch is for branch, i'd just copy the file over to master then. ws should \
> > be ok - hopefully...)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes. See QtDebug include in the first version :-)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=267349">267349</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/dialogparent/dialogparent.h <span style="color: \
grey">(08eef03)</span></li>
<li>kwin/effects/dialogparent/dialogparent.cpp <span style="color: \
grey">(cc663aa)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100887/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic