'Review Request: Add Rule/Property based composite blocking'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: Add Rule/Property based composite blocking
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2011-03-20 15:11:52
Message-ID: 20110320151152.5930.17372 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100893/
-----------------------------------------------------------

Review request for kwin.

Summary
-------

Allows windows (or users via the rule system) to block compositing while th=
ey're present.
The user still can resume and re-suspend compositing at any time (but if it=
 has originally been suspended for a blocking client it will be resumed the=
 moment the last blocking client disappears)

Outstanding issue is that the rules to not allow to apply by fullscreen mod=
e.
No real idea how we should handle this (add to rules globally or do some ru=
le specific)

Diffs
-----

  kwin/atoms.h 7d5752c =

  kwin/atoms.cpp 5e93b2a =

  kwin/client.h 0d479a0 =

  kwin/client.cpp ec60bde =

  kwin/composite.cpp 6783d32 =

  kwin/events.cpp 05cf864 =

  kwin/kcmkwin/kwinrules/ruleswidget.h ca44bf2 =

  kwin/kcmkwin/kwinrules/ruleswidget.cpp f9fc407 =

  kwin/kcmkwin/kwinrules/ruleswidgetbase.ui 74ac56b =

  kwin/manage.cpp 135a016 =

  kwin/rules.h 87b2055 =

  kwin/rules.cpp 9e4136a =

  kwin/workspace.h 3f6ad49 =

  kwin/workspace.cpp 3c77511 =

Diff: http://git.reviewboard.kde.org/r/100893/diff

Testing
-------

Rule based & "xprop -f _KDE_NET_WM_BLOCK_COMPOSITING 32a -set _KDE_NET_WM_B=
LOCK_COMPOSITING 1"
No client internal property setting tested (so far) but it should work as w=
ell... ;-)

Thanks,

Thomas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100893/">http://git.reviewboard.kde.org/r/100893/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Thomas Lübking.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Allows windows (or users via the rule system) to block compositing while \
they&#39;re present. The user still can resume and re-suspend compositing at any time \
(but if it has originally been suspended for a blocking client it will be resumed the \
moment the last blocking client disappears)

Outstanding issue is that the rules to not allow to apply by fullscreen mode.
No real idea how we should handle this (add to rules globally or do some rule \
specific)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Rule based &amp; &quot;xprop -f _KDE_NET_WM_BLOCK_COMPOSITING 32a -set \
_KDE_NET_WM_BLOCK_COMPOSITING 1&quot; No client internal property setting tested (so \
far) but it should work as well... ;-)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/atoms.h <span style="color: grey">(7d5752c)</span></li>

 <li>kwin/atoms.cpp <span style="color: grey">(5e93b2a)</span></li>

 <li>kwin/client.h <span style="color: grey">(0d479a0)</span></li>

 <li>kwin/client.cpp <span style="color: grey">(ec60bde)</span></li>

 <li>kwin/composite.cpp <span style="color: grey">(6783d32)</span></li>

 <li>kwin/events.cpp <span style="color: grey">(05cf864)</span></li>

 <li>kwin/kcmkwin/kwinrules/ruleswidget.h <span style="color: \
grey">(ca44bf2)</span></li>

 <li>kwin/kcmkwin/kwinrules/ruleswidget.cpp <span style="color: \
grey">(f9fc407)</span></li>

 <li>kwin/kcmkwin/kwinrules/ruleswidgetbase.ui <span style="color: \
grey">(74ac56b)</span></li>

 <li>kwin/manage.cpp <span style="color: grey">(135a016)</span></li>

 <li>kwin/rules.h <span style="color: grey">(87b2055)</span></li>

 <li>kwin/rules.cpp <span style="color: grey">(9e4136a)</span></li>

 <li>kwin/workspace.h <span style="color: grey">(3f6ad49)</span></li>

 <li>kwin/workspace.cpp <span style="color: grey">(3c77511)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100893/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 