--===============1764600383== Content-Type: multipart/alternative; boundary="===============8966500588541196630==" --===============8966500588541196630== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On March 19, 2011, 6:30 a.m., Martin Gr=C3=A4=C3=9Flin wrote: > > please push to both master and KDE/4.6. done, slightly adjusted for master (cause of signal/slot infrastructure) - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100887/#review2042 ----------------------------------------------------------- On March 18, 2011, 10:43 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100887/ > ----------------------------------------------------------- > = > (Updated March 18, 2011, 10:43 p.m.) > = > = > Review request for kwin. > = > = > Summary > ------- > = > Rewrite. > a) use QMap instead of QHash because of > b) don't keep every client but only (temporarily) the relevant ones (typi= cally << 10) and therefore > c) don't leak > d) the bloody QHash:operator[] should yell a compiler "#warning WRONG!" ;= -P > e) i raised the anim time from 200 -> 300, matter of personal taste thoug= h (it's esp. about fade out, because there's also another client appearing = -animatedly- pot. sucking cpu anyway, thus blocking updates for a short whi= le) > = > --- > :: I vote for an exceptional backport to branch despite it's a big patch. > :: It's only a tiny effect & little code and whatever regression i wrote = into it - i cannot be worse ;-P > :: (patch is for branch, i'd just copy the file over to master then. ws s= hould be ok - hopefully...) > = > = > This addresses bug 267349. > http://bugs.kde.org/show_bug.cgi?id=3D267349 > = > = > Diffs > ----- > = > kwin/effects/dialogparent/dialogparent.h 08eef03 = > kwin/effects/dialogparent/dialogparent.cpp cc663aa = > = > Diff: http://git.reviewboard.kde.org/r/100887/diff > = > = > Testing > ------- > = > Yes. See QtDebug include in the first version :-) > = > = > Thanks, > = > Thomas > = > --===============8966500588541196630== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100887/

On March 19th, 2011, 6:30 a.m., Martin Gr= =C3=A4=C3=9Flin wrote:

please pu=
sh to both master and KDE/4.6.
done, sligh=
tly adjusted for master (cause of signal/slot infrastructure)

- Thomas


On March 18th, 2011, 10:43 p.m., Thomas L=C3=BCbking wrote:

Review request for kwin.
By Thomas L=C3=BCbking.

Updated March 18, 2011, 10:43 p.m.

Descripti= on 

Rewrite.
a) use QMap instead of QHash because of
b) don't keep every client but only (temporarily) the relevant ones (ty=
pically << 10) and therefore
c) don't leak
d) the bloody QHash:operator[] should yell a compiler "#warning WRONG!=
" ;-P
e) i raised the anim time from 200 -> 300, matter of personal taste thou=
gh (it's esp. about fade out, because there's also another client a=
ppearing -animatedly- pot. sucking cpu anyway, thus blocking updates for a =
short while)

---
:: I vote for an exceptional backport to branch despite it's a big patc=
h.
:: It's only a tiny effect & little code and whatever regression i =
wrote into it - i cannot be worse ;-P
:: (patch is for branch, i'd just copy the file over to master then. ws=
 should be ok - hopefully...)

Testing <= /h1> 
Yes. See QtDebug include in the first version :-)
Bugs: 267349

Diffs=

  • kwin/effects/dialogparent/dialogparent.h (= 08eef03)
  • kwin/effects/dialogparent/dialogparent.cpp (cc663aa)

View Diff
--===============8966500588541196630==-- --===============1764600383== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============1764600383==--