This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100887/

On March 19th, 2011, 6:30 a.m., Martin Gräßlin wrote:

please push to both master and KDE/4.6.
done, slightly adjusted for master (cause of signal/slot infrastructure)

- Thomas


On March 18th, 2011, 10:43 p.m., Thomas Lübking wrote:

Review request for kwin.
By Thomas Lübking.

Updated March 18, 2011, 10:43 p.m.

Description

Rewrite.
a) use QMap instead of QHash because of
b) don't keep every client but only (temporarily) the relevant ones (typically << 10) and therefore
c) don't leak
d) the bloody QHash:operator[] should yell a compiler "#warning WRONG!" ;-P
e) i raised the anim time from 200 -> 300, matter of personal taste though (it's esp. about fade out, because there's also another client appearing -animatedly- pot. sucking cpu anyway, thus blocking updates for a short while)

---
:: I vote for an exceptional backport to branch despite it's a big patch.
:: It's only a tiny effect & little code and whatever regression i wrote into it - i cannot be worse ;-P
:: (patch is for branch, i'd just copy the file over to master then. ws should be ok - hopefully...)

Testing

Yes. See QtDebug include in the first version :-)
Bugs: 267349

Diffs

  • kwin/effects/dialogparent/dialogparent.h (08eef03)
  • kwin/effects/dialogparent/dialogparent.cpp (cc663aa)

View Diff