'Re: Review Request: clean up & simplify quicktile / quick maximize'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: clean up & simplify quicktile / quick maximize
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2011-03-08 22:15:54
Message-ID: 20110308221554.3331.36764 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On March 6, 2011, 6:11 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> > Ship it for version 1. We will soon get a review request which moves th=
e outline code into an own class which makes the moving all quicktiling cod=
e together rather obsolete ;-)
> =

> Thomas L=C3=BCbking wrote:
>     i should not have squashed it... ;-)
>     gonna merge fixes from v2 into v1 and hand apply.

commited, sorry i forgot to do an interactive rebase so the main commit mes=
sage is errr... useless :S

- Thomas

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100664/#review1815
-----------------------------------------------------------

On Feb. 16, 2011, 11:56 p.m., Thomas L=C3=BCbking wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100664/
> -----------------------------------------------------------
> =

> (Updated Feb. 16, 2011, 11:56 p.m.)
> =

> =

> Review request for kwin.
> =

> =

> Summary
> -------
> =

> clean up & simplify quicktile / quick maximize code
> in a second pass one should maybe align function names  & simplify the sh=
ortcut slots (using one slot reading qobject_cast<QAction*>(sender())->data=
()
> =

> =

> Diffs
> -----
> =

>   kwin/CMakeLists.txt eecf901 =

>   kwin/client.h e6f2ef4 =

>   kwin/events.cpp 390313f =

>   kwin/geometry.cpp 99e190b =

>   kwin/lib/kwinglobals.h 8bb7565 =

>   kwin/placement.cpp 0f3d4d3 =

>   kwin/quicktiling.cpp PRE-CREATION =

>   kwin/workspace.cpp 922de17 =

> =

> Diff: http://git.reviewboard.kde.org/r/100664/diff
> =

> =

> Testing
> -------
> =

> yes, everything from moving windows to edges to using shortcuts
> =

> =

> Thanks,
> =

> Thomas
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100664/">http://git.reviewboard.kde.org/r/100664/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On March 6th, 2011, 6:11 p.m., <b>Martin \
Gräßlin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship it for version 1. We will soon get a review request which moves the \
outline code into an own class which makes the moving all quicktiling code together \
rather obsolete ;-)</pre>  </blockquote>

 <p>On March 6th, 2011, 10:26 p.m., <b>Thomas Lübking</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i should not have \
squashed it... ;-) gonna merge fixes from v2 into v1 and hand apply.</pre>
 </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">commited, sorry i forgot \
to do an interactive rebase so the main commit message is errr... useless :S</pre> \
<br />

<p>- Thomas</p>

<br />
<p>On February 16th, 2011, 11:56 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Feb. 16, 2011, 11:56 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">clean up &amp; simplify quicktile / quick maximize code in a second pass \
one should maybe align function names  &amp; simplify the shortcut slots (using one \
slot reading qobject_cast&lt;QAction*&gt;(sender())-&gt;data()</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes, everything from moving windows to edges to using shortcuts</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/CMakeLists.txt <span style="color: grey">(eecf901)</span></li>

 <li>kwin/client.h <span style="color: grey">(e6f2ef4)</span></li>

 <li>kwin/events.cpp <span style="color: grey">(390313f)</span></li>

 <li>kwin/geometry.cpp <span style="color: grey">(99e190b)</span></li>

 <li>kwin/lib/kwinglobals.h <span style="color: grey">(8bb7565)</span></li>

 <li>kwin/placement.cpp <span style="color: grey">(0f3d4d3)</span></li>

 <li>kwin/quicktiling.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kwin/workspace.cpp <span style="color: grey">(922de17)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100664/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 