From kwin Tue Mar 08 22:15:54 2011 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Tue, 08 Mar 2011 22:15:54 +0000 To: kwin Subject: Re: Review Request: clean up & simplify quicktile / quick maximize Message-Id: <20110308221554.3331.36764 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=129962270131086 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1314566126==" --===============1314566126== Content-Type: multipart/alternative; boundary="===============5527506005103105041==" --===============5527506005103105041== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On March 6, 2011, 6:11 p.m., Martin Gr=C3=A4=C3=9Flin wrote: > > Ship it for version 1. We will soon get a review request which moves th= e outline code into an own class which makes the moving all quicktiling cod= e together rather obsolete ;-) > = > Thomas L=C3=BCbking wrote: > i should not have squashed it... ;-) > gonna merge fixes from v2 into v1 and hand apply. commited, sorry i forgot to do an interactive rebase so the main commit mes= sage is errr... useless :S - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100664/#review1815 ----------------------------------------------------------- On Feb. 16, 2011, 11:56 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100664/ > ----------------------------------------------------------- > = > (Updated Feb. 16, 2011, 11:56 p.m.) > = > = > Review request for kwin. > = > = > Summary > ------- > = > clean up & simplify quicktile / quick maximize code > in a second pass one should maybe align function names & simplify the sh= ortcut slots (using one slot reading qobject_cast(sender())->data= () > = > = > Diffs > ----- > = > kwin/CMakeLists.txt eecf901 = > kwin/client.h e6f2ef4 = > kwin/events.cpp 390313f = > kwin/geometry.cpp 99e190b = > kwin/lib/kwinglobals.h 8bb7565 = > kwin/placement.cpp 0f3d4d3 = > kwin/quicktiling.cpp PRE-CREATION = > kwin/workspace.cpp 922de17 = > = > Diff: http://git.reviewboard.kde.org/r/100664/diff > = > = > Testing > ------- > = > yes, everything from moving windows to edges to using shortcuts > = > = > Thanks, > = > Thomas > = > --===============5527506005103105041== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100664/

On March 6th, 2011, 6:11 p.m., Martin Gr=C3= =A4=C3=9Flin wrote:

Ship it f=
or version 1. We will soon get a review request which moves the outline cod=
e into an own class which makes the moving all quicktiling code together ra=
ther obsolete ;-)

On March 6th, 2011, 10:26 p.m., Thomas L=C3=BCbking wrote:

i should =
not have squashed it... ;-)
gonna merge fixes from v2 into v1 and hand apply.
commited, s=
orry i forgot to do an interactive rebase so the main commit message is err=
r... useless :S

- Thomas


On February 16th, 2011, 11:56 p.m., Thomas L=C3=BCbking wrote:

Review request for kwin.
By Thomas L=C3=BCbking.

Updated Feb. 16, 2011, 11:56 p.m.

Descripti= on 

clean up & simplify quicktile / quick maximize code
in a second pass one should maybe align function names  & simplify the =
shortcut slots (using one slot reading qobject_cast<QAction*>(sender(=
))->data()

Testing <= /h1> 
yes, everything from moving windows to edges to using shortc=
uts

Diffs=

  • kwin/CMakeLists.txt (eecf901)
  • kwin/client.h (e6f2ef4)
  • kwin/events.cpp (390313f)
  • kwin/geometry.cpp (99e190b)
  • kwin/lib/kwinglobals.h (8bb7565)
  • kwin/placement.cpp (0f3d4d3)
  • kwin/quicktiling.cpp (PRE-CREATION)=
  • kwin/workspace.cpp (922de17)

View Diff
--===============5527506005103105041==-- --===============1314566126== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============1314566126==--