This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100664/

On March 6th, 2011, 6:11 p.m., Martin Gräßlin wrote:

Ship it for version 1. We will soon get a review request which moves the outline code into an own class which makes the moving all quicktiling code together rather obsolete ;-)

On March 6th, 2011, 10:26 p.m., Thomas Lübking wrote:

i should not have squashed it... ;-)
gonna merge fixes from v2 into v1 and hand apply.
commited, sorry i forgot to do an interactive rebase so the main commit message is errr... useless :S

- Thomas


On February 16th, 2011, 11:56 p.m., Thomas Lübking wrote:

Review request for kwin.
By Thomas Lübking.

Updated Feb. 16, 2011, 11:56 p.m.

Description

clean up & simplify quicktile / quick maximize code
in a second pass one should maybe align function names  & simplify the shortcut slots (using one slot reading qobject_cast<QAction*>(sender())->data()

Testing

yes, everything from moving windows to edges to using shortcuts

Diffs

  • kwin/CMakeLists.txt (eecf901)
  • kwin/client.h (e6f2ef4)
  • kwin/events.cpp (390313f)
  • kwin/geometry.cpp (99e190b)
  • kwin/lib/kwinglobals.h (8bb7565)
  • kwin/placement.cpp (0f3d4d3)
  • kwin/quicktiling.cpp (PRE-CREATION)
  • kwin/workspace.cpp (922de17)

View Diff