'Re: Review Request: Fix loading of curve in softbrush presets'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Fix loading of curve in softbrush presets
From:       Lukáš Tvrdý <lukast.dev () gmail ! com>
Date:       2010-12-05 12:59:23
Message-ID: 20101205125923.28056.8648 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6046/#review9135
-----------------------------------------------------------

Ship it!

Seems fine to me.

Minor thing: I would document in the code why you decided to add curve string to the \
base class as it is specialization of the curve* mask generators.

- Lukáš

On 2010-12-04 18:49:14, Sven Langkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6046/
> -----------------------------------------------------------
> 
> (Updated 2010-12-04 18:49:14)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Patch fixes loading of softbrush curves from presets. For 2.3 branch
> 
> 
> This addresses bug 258420.
> https://bugs.kde.org/show_bug.cgi?id=258420
> 
> 
> Diffs
> -----
> 
> branches/koffice/2.3/koffice/krita/image/kis_base_mask_generator.h 1203569 
> branches/koffice/2.3/koffice/krita/image/kis_base_mask_generator.cpp 1203569 
> branches/koffice/2.3/koffice/krita/image/kis_curve_circle_mask_generator.cpp \
> 1203569  branches/koffice/2.3/koffice/krita/image/kis_curve_rect_mask_generator.cpp \
> 1203569  branches/koffice/2.3/koffice/krita/plugins/paintops/libpaintop/kis_auto_brush_widget.cpp \
> 1203569  
> Diff: http://svn.reviewboard.kde.org/r/6046/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sven
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6046/">http://svn.reviewboard.kde.org/r/6046/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems fine to me.

Minor thing: I would document in the code why you decided to add curve string to the \
base class as it is specialization of the curve* mask generators.</pre>  <br />

<p>- Lukáš</p>

<br />
<p>On December 4th, 2010, 6:49 p.m., Sven Langkamp wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Sven Langkamp.</div>

<p style="color: grey;"><i>Updated 2010-12-04 18:49:14</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch fixes loading of softbrush curves from presets. For 2.3 \
branch</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=258420">258420</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>branches/koffice/2.3/koffice/krita/image/kis_base_mask_generator.h <span \
style="color: grey">(1203569)</span></li>

 <li>branches/koffice/2.3/koffice/krita/image/kis_base_mask_generator.cpp <span \
style="color: grey">(1203569)</span></li>

 <li>branches/koffice/2.3/koffice/krita/image/kis_curve_circle_mask_generator.cpp \
<span style="color: grey">(1203569)</span></li>

 <li>branches/koffice/2.3/koffice/krita/image/kis_curve_rect_mask_generator.cpp <span \
style="color: grey">(1203569)</span></li>

 <li>branches/koffice/2.3/koffice/krita/plugins/paintops/libpaintop/kis_auto_brush_widget.cpp \
<span style="color: grey">(1203569)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6046/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 