From koffice-devel Sun Dec 05 12:59:23 2010 From: =?utf-8?b?THVrw6HFoSBUdnJkw70=?= Date: Sun, 05 Dec 2010 12:59:23 +0000 To: koffice-devel Subject: Re: Review Request: Fix loading of curve in softbrush presets Message-Id: <20101205125923.28056.8648 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=koffice-devel&m=129155401222905 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0161900538==" --===============0161900538== Content-Type: multipart/alternative; boundary="===============1462170654042508197==" --===============1462170654042508197== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6046/#review9135 ----------------------------------------------------------- Ship it! Seems fine to me. Minor thing: I would document in the code why you decided to add curve stri= ng to the base class as it is specialization of the curve* mask generators. - Luk=C3=A1=C5=A1 On 2010-12-04 18:49:14, Sven Langkamp wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6046/ > ----------------------------------------------------------- > = > (Updated 2010-12-04 18:49:14) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > Patch fixes loading of softbrush curves from presets. For 2.3 branch > = > = > This addresses bug 258420. > https://bugs.kde.org/show_bug.cgi?id=3D258420 > = > = > Diffs > ----- > = > branches/koffice/2.3/koffice/krita/image/kis_base_mask_generator.h 1203= 569 = > branches/koffice/2.3/koffice/krita/image/kis_base_mask_generator.cpp 12= 03569 = > branches/koffice/2.3/koffice/krita/image/kis_curve_circle_mask_generato= r.cpp 1203569 = > branches/koffice/2.3/koffice/krita/image/kis_curve_rect_mask_generator.= cpp 1203569 = > branches/koffice/2.3/koffice/krita/plugins/paintops/libpaintop/kis_auto= _brush_widget.cpp 1203569 = > = > Diff: http://svn.reviewboard.kde.org/r/6046/diff > = > = > Testing > ------- > = > = > Thanks, > = > Sven > = > --===============1462170654042508197== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6046/

Ship it!

Seems fine=
 to me.

Minor thing: I would document in the code why you decided to add curve stri=
ng to the base class as it is specialization of the curve* mask generators.=

- Luk=C3=A1=C5=A1


On December 4th, 2010, 6:49 p.m., Sven Langkamp wrote:

Review request for KOffice.
By Sven Langkamp.

Updated 2010-12-04 18:49:14

Descripti= on 

Patch fixes loading of softbrush curves from presets. For 2.=
3 branch
Bugs: 258420

Diffs=

  • branches/koffice/2.3/koffice/krita/image/kis_base_mask_generator.h (1203569)
  • branches/koffice/2.3/koffice/krita/image/kis_base_mask_generator.cpp <= span style=3D"color: grey">(1203569)
  • branches/koffice/2.3/koffice/krita/image/kis_curve_circle_mask_generat= or.cpp (1203569)
  • branches/koffice/2.3/koffice/krita/image/kis_curve_rect_mask_generator= .cpp (1203569)
  • branches/koffice/2.3/koffice/krita/plugins/paintops/libpaintop/kis_aut= o_brush_widget.cpp (1203569)

View Diff
--===============1462170654042508197==-- --===============0161900538== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============0161900538==--