This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6046/

Ship it!

Seems fine to me.

Minor thing: I would document in the code why you decided to add curve string to the base class as it is specialization of the curve* mask generators.

- Lukáš


On December 4th, 2010, 6:49 p.m., Sven Langkamp wrote:

Review request for KOffice.
By Sven Langkamp.

Updated 2010-12-04 18:49:14

Description 

Patch fixes loading of softbrush curves from presets. For 2.3 branch
Bugs: 258420

Diffs

  • branches/koffice/2.3/koffice/krita/image/kis_base_mask_generator.h (1203569)
  • branches/koffice/2.3/koffice/krita/image/kis_base_mask_generator.cpp (1203569)
  • branches/koffice/2.3/koffice/krita/image/kis_curve_circle_mask_generator.cpp (1203569)
  • branches/koffice/2.3/koffice/krita/image/kis_curve_rect_mask_generator.cpp (1203569)
  • branches/koffice/2.3/koffice/krita/plugins/paintops/libpaintop/kis_auto_brush_widget.cpp (1203569)

View Diff