[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Optimize KoXmlNS
From: "Marijn Kruisselbrink" <m.kruisselbrink () student ! tue ! nl>
Date: 2010-10-28 6:14:59
Message-ID: 20101028061459.20237.30865 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5698/#review8407
-----------------------------------------------------------
Ship it!
- Marijn
On 2010-10-27 06:06:49, Thorsten Zachmann wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5698/
> -----------------------------------------------------------
> =
> (Updated 2010-10-27 06:06:49)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> Optimize loading speed by using QString in KoXmlNS instead of char *.
> =
> This reduces the number of conversions form char * to QString during loa=
ding quite a lot.
> =
> =
> Diffs
> -----
> =
> trunk/koffice/filters/kpresenter/kpr2odf/Filterkpr2odf.cpp 1188346 =
> trunk/koffice/kspread/Cell.cpp 1188346 =
> trunk/koffice/kspread/Sheet.cpp 1188346 =
> trunk/koffice/libs/flake/KoFrameShape.h 1188346 =
> trunk/koffice/libs/flake/KoFrameShape.cpp 1188346 =
> trunk/koffice/libs/flake/KoShape.h 1188346 =
> trunk/koffice/libs/flake/KoShape.cpp 1188346 =
> trunk/koffice/libs/flake/KoShapeLoadingContext.h 1188346 =
> trunk/koffice/libs/flake/KoShape_p.h 1188346 =
> trunk/koffice/libs/odf/KoOasisSettings.h 1188346 =
> trunk/koffice/libs/odf/KoOdfGraphicStyles.cpp 1188346 =
> trunk/koffice/libs/odf/KoOdfLoadingContext.h 1188346 =
> trunk/koffice/libs/odf/KoOdfLoadingContext.cpp 1188346 =
> trunk/koffice/libs/odf/KoXmlNS.h 1188346 =
> trunk/koffice/libs/odf/KoXmlNS.cpp 1188346 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5698/diff
> =
> =
> Testing
> -------
> =
> All tests work as before. Also tested with loading of different documents=
and all works as expected.
> =
> =
> Thanks,
> =
> Thorsten
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5698/">http://svn.reviewboard.kde.org/r/5698/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- Marijn</p>
<br />
<p>On October 27th, 2010, 6:06 a.m., Thorsten Zachmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Thorsten Zachmann.</div>
<p style="color: grey;"><i>Updated 2010-10-27 06:06:49</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Optimize loading speed by using QString in KoXmlNS instead of char *.
This reduces the number of conversions form char * to QString during loading quite a \
lot.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">All tests work as before. Also tested with loading of different \
documents and all works as expected.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/filters/kpresenter/kpr2odf/Filterkpr2odf.cpp <span style="color: \
grey">(1188346)</span></li>
<li>trunk/koffice/kspread/Cell.cpp <span style="color: grey">(1188346)</span></li>
<li>trunk/koffice/kspread/Sheet.cpp <span style="color: grey">(1188346)</span></li>
<li>trunk/koffice/libs/flake/KoFrameShape.h <span style="color: \
grey">(1188346)</span></li>
<li>trunk/koffice/libs/flake/KoFrameShape.cpp <span style="color: \
grey">(1188346)</span></li>
<li>trunk/koffice/libs/flake/KoShape.h <span style="color: \
grey">(1188346)</span></li>
<li>trunk/koffice/libs/flake/KoShape.cpp <span style="color: \
grey">(1188346)</span></li>
<li>trunk/koffice/libs/flake/KoShapeLoadingContext.h <span style="color: \
grey">(1188346)</span></li>
<li>trunk/koffice/libs/flake/KoShape_p.h <span style="color: \
grey">(1188346)</span></li>
<li>trunk/koffice/libs/odf/KoOasisSettings.h <span style="color: \
grey">(1188346)</span></li>
<li>trunk/koffice/libs/odf/KoOdfGraphicStyles.cpp <span style="color: \
grey">(1188346)</span></li>
<li>trunk/koffice/libs/odf/KoOdfLoadingContext.h <span style="color: \
grey">(1188346)</span></li>
<li>trunk/koffice/libs/odf/KoOdfLoadingContext.cpp <span style="color: \
grey">(1188346)</span></li>
<li>trunk/koffice/libs/odf/KoXmlNS.h <span style="color: grey">(1188346)</span></li>
<li>trunk/koffice/libs/odf/KoXmlNS.cpp <span style="color: \
grey">(1188346)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5698/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic