From koffice-devel Thu Oct 28 06:14:59 2010 From: "Marijn Kruisselbrink" Date: Thu, 28 Oct 2010 06:14:59 +0000 To: koffice-devel Subject: Re: Review Request: Optimize KoXmlNS Message-Id: <20101028061459.20237.30865 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=koffice-devel&m=128824749002560 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0252262319==" --===============0252262319== Content-Type: multipart/alternative; boundary="===============4079079405190600477==" --===============4079079405190600477== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5698/#review8407 ----------------------------------------------------------- Ship it! - Marijn On 2010-10-27 06:06:49, Thorsten Zachmann wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5698/ > ----------------------------------------------------------- > = > (Updated 2010-10-27 06:06:49) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > Optimize loading speed by using QString in KoXmlNS instead of char *. > = > This reduces the number of conversions form char * to QString during loa= ding quite a lot. > = > = > Diffs > ----- > = > trunk/koffice/filters/kpresenter/kpr2odf/Filterkpr2odf.cpp 1188346 = > trunk/koffice/kspread/Cell.cpp 1188346 = > trunk/koffice/kspread/Sheet.cpp 1188346 = > trunk/koffice/libs/flake/KoFrameShape.h 1188346 = > trunk/koffice/libs/flake/KoFrameShape.cpp 1188346 = > trunk/koffice/libs/flake/KoShape.h 1188346 = > trunk/koffice/libs/flake/KoShape.cpp 1188346 = > trunk/koffice/libs/flake/KoShapeLoadingContext.h 1188346 = > trunk/koffice/libs/flake/KoShape_p.h 1188346 = > trunk/koffice/libs/odf/KoOasisSettings.h 1188346 = > trunk/koffice/libs/odf/KoOdfGraphicStyles.cpp 1188346 = > trunk/koffice/libs/odf/KoOdfLoadingContext.h 1188346 = > trunk/koffice/libs/odf/KoOdfLoadingContext.cpp 1188346 = > trunk/koffice/libs/odf/KoXmlNS.h 1188346 = > trunk/koffice/libs/odf/KoXmlNS.cpp 1188346 = > = > Diff: http://svn.reviewboard.kde.org/r/5698/diff > = > = > Testing > ------- > = > All tests work as before. Also tested with loading of different documents= and all works as expected. > = > = > Thanks, > = > Thorsten > = > --===============4079079405190600477== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5698/

Ship it!

- Marijn

On October 27th, 2010, 6:06 a.m., Thorsten Zachmann wrote:

Review request for KOffice.

By Thorsten Zachmann.

Updated 2010-10-27 06:06:49

Descripti= on

Optimize loading speed by using QString in KoXmlNS instead o=
f char *.

This reduces the number of conversions form char *  to QString during loadi=
ng quite a lot.

Testing <= /h1>

All tests work as before. Also tested with loading of differ=
ent documents and all works as expected.

Diffs=

trunk/koffice/filters/kpresenter/kpr2odf/Filterkpr2odf.cpp (1188346)
trunk/koffice/kspread/Cell.cpp (1188346)
trunk/koffice/kspread/Sheet.cpp (1188346)<= /span>
trunk/koffice/libs/flake/KoFrameShape.h (1= 188346)
trunk/koffice/libs/flake/KoFrameShape.cpp = (1188346)
trunk/koffice/libs/flake/KoShape.h (118834= 6)
trunk/koffice/libs/flake/KoShape.cpp (1188= 346)
trunk/koffice/libs/flake/KoShapeLoadingContext.h (1188346)
trunk/koffice/libs/flake/KoShape_p.h (1188= 346)
trunk/koffice/libs/odf/KoOasisSettings.h (= 1188346)
trunk/koffice/libs/odf/KoOdfGraphicStyles.cpp (1188346)
trunk/koffice/libs/odf/KoOdfLoadingContext.h (1188346)
trunk/koffice/libs/odf/KoOdfLoadingContext.cpp (1188346)
trunk/koffice/libs/odf/KoXmlNS.h (1188346)=
trunk/koffice/libs/odf/KoXmlNS.cpp (118834= 6)

--===============4079079405190600477==-- --===============0252262319== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============0252262319==--