[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Please review for Kivio shape(stencil) selection docker design
From:       Cyrille Berger Skott <cberger () cberger ! net>
Date:       2010-10-28 6:16:59
Message-ID: 201010280816.59929.cberger () cberger ! net
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Thursday 28 October 2010, Thorsten Zachmann wrote:
> E.g. the placeholder shape sets that to true and will therefore 
> not shown in the add shapes docker.
Not yet.

Should I commit the attached patch ?

-- 
Cyrille Berger Skott

[Attachment #5 (text/html)]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"> <html><head><meta name="qrichtext" \
content="1" /><style type="text/css"> p, li { white-space: pre-wrap; }
</style></head><body style=" font-family:'DejaVu Sans Mono'; font-size:9pt; \
font-weight:400; font-style:normal;"> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">On Thursday 28 October 2010, Thorsten Zachmann wrote:</p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">&gt; E.g. the placeholder \
shape sets that to true and will therefore </p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">&gt; not shown in the add shapes docker.</p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Not yet.</p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"></p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Should I commit the attached \
patch ?</p> <p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"></p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">-- </p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">Cyrille Berger Skott</p></body></html>


["hide_plugin_comment.patch" (text/x-patch)]

Index: pluginshape/PluginShapeFactory.cpp
===================================================================
--- pluginshape/PluginShapeFactory.cpp	(revision 1190571)
+++ pluginshape/PluginShapeFactory.cpp	(working copy)
@@ -39,6 +39,7 @@
     //setIcon("video-x-generic");
     setOdfElementNames(KoXmlNS::draw, QStringList("plugin"));
     setLoadingPriority(9);
+    setHidden(true);
 }
 
 KoShape *PluginShapeFactory::createDefaultShape(KoResourceManager *documentResources) const
Index: commentshape/CommentShapeFactory.cpp
===================================================================
--- commentshape/CommentShapeFactory.cpp	(revision 1189665)
+++ commentshape/CommentShapeFactory.cpp	(working copy)
@@ -30,6 +30,7 @@
 : KoShapeFactoryBase(parent, COMMENTSHAPEID, i18n("Comment"))
 {
     setOdfElementNames(KoXmlNS::officeooo, QStringList("annotation"));
+    setHidden(true);
 }
 
 CommentShapeFactory::~CommentShapeFactory()


_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic