This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5698/

Ship it!

- Marijn


On October 27th, 2010, 6:06 a.m., Thorsten Zachmann wrote:

Review request for KOffice.
By Thorsten Zachmann.

Updated 2010-10-27 06:06:49

Description 

Optimize loading speed by using QString in KoXmlNS instead of char *.

This reduces the number of conversions form char *  to QString during loading quite a lot.

Testing 

All tests work as before. Also tested with loading of different documents and all works as expected.

Diffs

  • trunk/koffice/filters/kpresenter/kpr2odf/Filterkpr2odf.cpp (1188346)
  • trunk/koffice/kspread/Cell.cpp (1188346)
  • trunk/koffice/kspread/Sheet.cpp (1188346)
  • trunk/koffice/libs/flake/KoFrameShape.h (1188346)
  • trunk/koffice/libs/flake/KoFrameShape.cpp (1188346)
  • trunk/koffice/libs/flake/KoShape.h (1188346)
  • trunk/koffice/libs/flake/KoShape.cpp (1188346)
  • trunk/koffice/libs/flake/KoShapeLoadingContext.h (1188346)
  • trunk/koffice/libs/flake/KoShape_p.h (1188346)
  • trunk/koffice/libs/odf/KoOasisSettings.h (1188346)
  • trunk/koffice/libs/odf/KoOdfGraphicStyles.cpp (1188346)
  • trunk/koffice/libs/odf/KoOdfLoadingContext.h (1188346)
  • trunk/koffice/libs/odf/KoOdfLoadingContext.cpp (1188346)
  • trunk/koffice/libs/odf/KoXmlNS.h (1188346)
  • trunk/koffice/libs/odf/KoXmlNS.cpp (1188346)

View Diff